Do not apply force_swift_local_debug_options transition. #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ees this transition is present, it adds a transition directory name fragment, even if the build settings are identical to having the local_debug_options_enabled flag specified on command line.
segiddins
approved these changes
Oct 6, 2020
rules/xcodeproj.bzl
Outdated
| @@ -674,7 +674,7 @@ def _xcodeproj_impl(ctx): | |||
| xcodeproj = rule( | |||
| implementation = _xcodeproj_impl, | |||
| doc = """\ | |||
| Generates a Xcode project file (.xcodeproj) with a reasonable set of defaults | |||
| Generates a Xcode project file (.xcodeproj) with a reasonable set of defaults. Specify the --//rules:local_debug_options_enabled when generating the project to ensure debugging of swiftmodules works. | |||
There was a problem hiding this comment.
include the repository in the flag name
Co-authored-by: Samuel Giddins <segiddins@squareup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There should be no difference between applying the local_debug_options_enabled build setting via the command line vs applying it with a transition.
But (possibly due to this bug: bazelbuild/bazel#12171), when bazel sees this transition is present, it adds a transition directory name fragment, even if the build settings are identical to having the local_debug_options_enabled flag specified on command line. This results in a different output directory fragment for dependent artifacts when developers call
bazel run xcodeprojectwith the transition applied vs. when the xcodeproject invokesbazel build <targetname> --local_debug_options_enabled.