Support gc_goopts and gc_linkopts attributes #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmbethe09
reviewed
Mar 7, 2017
go/def.bzl
Outdated
| @@ -206,7 +206,8 @@ def _is_external(p): | |||
| """Checks if the string starts with ../""" | |||
| return p[0:3] == '../' | |||
|
|
|||
| def emit_go_compile_action(ctx, sources, deps, out_lib, extra_objects=[]): | |||
| def _emit_go_compile_action(ctx, sources, deps, out_lib, | |||
| extra_objects=[], gc_goopts=[]): | |||
There was a problem hiding this comment.
I think skylark is immune to the python bug where a default argument of [] is bad, but I still see common skylark practice to follow the convention of 'None' as the default value and then a
if not gc_goopts:
gc_goopts = []
There was a problem hiding this comment.
I'm not sure if Skylark is affected by this. I figured it's better to just make the arguments explicit though.
Will submit when CI is done again (Mac build is taking forever to run these days).
go_library, cgo_library, go_binary, and go_test now support the gc_goopts attribute. This is a list of flags to pass to the Go compiler. go_binary and go_test also support the gc_linkopts attribute. This is a list of flags to be passed to the Go linker. Note that _emit_go_compile_action and _emit_go_link_action have had small interface changes and are now private. I didn't see any uses of these functions on GitHub, and I'd like to avoid having people depend on them in the future. Fixes bazel-contrib#217
f36235a to
be1b4e8
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go_library, cgo_library, go_binary, and go_test now support the
gc_goopts attribute. This is a list of flags to pass to the Go
compiler.
go_binary and go_test also support the gc_linkopts attribute. This is
a list of flags to be passed to the Go linker.
Note that _emit_go_compile_action and _emit_go_link_action have had
small interface changes and are now private. I didn't see any uses of
these functions on GitHub, and I'd like to avoid having people depend
on them in the future.
Fixes #217