Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for gc_linkopts #217

Closed
mikedanese opened this issue Dec 6, 2016 · 0 comments
Closed

Add support for gc_linkopts #217

mikedanese opened this issue Dec 6, 2016 · 0 comments

Comments

@mikedanese
Copy link
Contributor

With the same functionality as internal go rules.
@mikedanese mikedanese mentioned this issue Feb 24, 2017
Closed
@jayconrod jayconrod mentioned this issue Mar 2, 2017
Closed
jayconrod pushed a commit to jayconrod/rules_go that referenced this issue Mar 6, 2017
Support gc_goopts and gc_linkopts attributes
2866415 
go_library, cgo_library, go_binary, and go_test now support the
gc_goopts attribute. This is a list list of flags to be passed to the
Go compiler.

go_binary and go_test also support the gc_linkopts attribute. This is
a list of flags to be passed to the Go linker.

Fixes bazel-contrib#217
jayconrod pushed a commit to jayconrod/rules_go that referenced this issue Mar 6, 2017
Support gc_goopts and gc_linkopts attributes
596fd1d 
go_library, cgo_library, go_binary, and go_test now support the
gc_goopts attribute. This is a list list of flags to be passed to the
Go compiler.

go_binary and go_test also support the gc_linkopts attribute. This is
a list of flags to be passed to the Go linker.

Fixes bazel-contrib#217
jayconrod pushed a commit to jayconrod/rules_go that referenced this issue Mar 7, 2017
Support gc_goopts and gc_linkopts attributes
2f614b3 
go_library, cgo_library, go_binary, and go_test now support the
gc_goopts attribute. This is a list list of flags to be passed to the
Go compiler.

go_binary and go_test also support the gc_linkopts attribute. This is
a list of flags to be passed to the Go linker.

Fixes bazel-contrib#217
jayconrod pushed a commit to jayconrod/rules_go that referenced this issue Mar 7, 2017
Support gc_goopts and gc_linkopts attributes
f36235a 
go_library, cgo_library, go_binary, and go_test now support the
gc_goopts attribute. This is a list of flags to pass to the Go
compiler.

go_binary and go_test also support the gc_linkopts attribute. This is
a list of flags to be passed to the Go linker.

Note that _emit_go_compile_action and _emit_go_link_action have had
small interface changes and are now private. I didn't see any uses of
these functions on GitHub, and I'd like to avoid having people depend
on them in the future.

Fixes bazel-contrib#217
@jayconrod jayconrod mentioned this issue Mar 7, 2017
Merged
jayconrod pushed a commit to jayconrod/rules_go that referenced this issue Mar 8, 2017
Support gc_goopts and gc_linkopts attributes
be1b4e8 
go_library, cgo_library, go_binary, and go_test now support the
gc_goopts attribute. This is a list of flags to pass to the Go
compiler.

go_binary and go_test also support the gc_linkopts attribute. This is
a list of flags to be passed to the Go linker.

Note that _emit_go_compile_action and _emit_go_link_action have had
small interface changes and are now private. I didn't see any uses of
these functions on GitHub, and I'd like to avoid having people depend
on them in the future.

Fixes bazel-contrib#217
jayconrod added a commit that referenced this issue Mar 8, 2017
@jayconrod
Support gc_goopts and gc_linkopts attributes (#291)
ce7fc8b 
go_library, cgo_library, go_binary, and go_test now support the
gc_goopts attribute. This is a list of flags to pass to the Go
compiler.

go_binary and go_test also support the gc_linkopts attribute. This is
a list of flags to be passed to the Go linker.

Note that _emit_go_compile_action and _emit_go_link_action have had
small interface changes and are now private. I didn't see any uses of
these functions on GitHub, and I'd like to avoid having people depend
on them in the future.

Fixes #217
@toby-jazz toby-jazz mentioned this issue Mar 13, 2017
Closed
@jayconrod jayconrod mentioned this issue Jun 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mikedanese