Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #1042 regarding pvc deploys when component is not enabled #1043

Merged

Conversation

fsschmitt
Copy link
Contributor

Signed-off-by: fsschmitt 492108+fsschmitt@users.noreply.github.com

Q A
Bug fix? yes
Related tickets fixes #1042
License Apache 2.0

What's in this PR?

Fixes the issue regarding PVC were being deployed even when component was enabled: false

Checklist

  • User guide and development docs updated (if needed)
  • Related Helm chart(s) updated (if needed)

…t enabled

Signed-off-by: fsschmitt <492108+fsschmitt@users.noreply.github.com>
Signed-off-by: fsschmitt <492108+fsschmitt@users.noreply.github.com>
@ahma ahma requested review from ahma and tarokkk February 18, 2020 15:02
Copy link
Contributor

@ahma ahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks @fsschmitt

@tarokkk tarokkk merged commit 5bb9c69 into banzaicloud:master Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Thanos Chart] PVC is created even when component is disabled
3 participants