Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Thanos Chart] PVC is created even when component is disabled #1042

Closed
fsschmitt opened this issue Feb 18, 2020 · 0 comments · Fixed by #1043
Closed

[Thanos Chart] PVC is created even when component is disabled #1042

fsschmitt opened this issue Feb 18, 2020 · 0 comments · Fixed by #1043

Comments

@fsschmitt
Copy link
Contributor

Describe the bug
Whenever Thanos Store / Compactor are enabled: false the chart still deploys the PVC if specified.

Steps to reproduce the issue:
Set store.enabled: true and have a PVC specified on store.persistentVolumeClaim.

Expected behavior
If the component is not enabled, then the PVC should not be created.
fsschmitt added a commit to fsschmitt/banzai-charts that referenced this issue Feb 18, 2020
@fsschmitt
Fix issue banzaicloud#1042 regarding pvc deploys when component is no…
f788b0d 
…t enabled

Signed-off-by: fsschmitt <492108+fsschmitt@users.noreply.github.com>
@fsschmitt fsschmitt mentioned this issue Feb 18, 2020
Merged
2 tasks
tarokkk pushed a commit that referenced this issue Feb 24, 2020
@fsschmitt @tarokkk
Fix issue #1042 regarding pvc deploys when component is not enabled
5bb9c69 
Signed-off-by: fsschmitt <492108+fsschmitt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue #1042 regarding pvc deploys when component is not enabled fsschmitt/banzai-charts
1 participant
@fsschmitt