Disable default kafka server initialisation #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
pregnor
reviewed
Oct 12, 2022
pregnor
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the default settings in the bootstrap kafka server validator and only create a consumer if the settings are actually configured.
What's in this PR?
Only create a kafka consumer if explicitly set. Prior to this fix, the "bootstrap" kafka consumer was always being created even if there were no "KAFKASERVER_*" settings.
Update kafka-go package to latest.
Why?
Since the kafka server requires infrastructure to be in place outside of allspark to operate, it doesn't align with the other server implementations and it should only be started if the required bootstrap server is provided.
Checklist