Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default kafka bootstrap consumer behavior #28

Closed

Conversation

tiswanso
Copy link

@tiswanso tiswanso commented Oct 6, 2022

Remove the default settings in the bootstrap kafka server validator and only create a consumer if the settings are actually configured.

Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
License Apache 2.0

What's in this PR?

Only create a kafka consumer if explicitly set. Prior to this fix, the "bootstrap" kafka consumer was always being created even if there were no "KAFKASERVER_*" settings.

Why?

It's confusing to have an arbitrary default kafka consumer register with the kafka server without specifically configuring allspark to do that.

Checklist

only create a kafka consumer if explicitly set
@tiswanso tiswanso force-pushed the fix/kafka-nodefault-consumer branch from 7fa55b8 to eba8204 Compare October 7, 2022 16:38
Copy link
Member

@hi-im-aren hi-im-aren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait with this one a little bit, I want to also add the change so the producer doesn't create a topic automatically if it doesn't exist. :)

@hi-im-aren
Copy link
Member

Closing this one for #29

@hi-im-aren hi-im-aren closed this Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants