If we catch the wrong exception in AssertThrows, print the description of the exception #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbeyer
requested changes
Feb 26, 2020
There was a problem hiding this comment.
Thank you very much, very cool! I request a few minor changes. You can btw ignore the failed Codacy check (it's just complaining that it cannot check this PR because it is not enabled for any branch other than master; so I don't know why it is complaining at all).
This makes it easier to debug the failure fixes banditcpp#47
9925f93 to
78f6b96
Compare
|
Pushed a new version, sorry for the typos, seems like I was a bit sidetracked yesterday :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to debug the failure
fixes #47