Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show more information if AssertThrows fails #47

Closed
Cogitri opened this issue Feb 24, 2020 · 2 comments
Closed

Show more information if AssertThrows fails #47

Cogitri opened this issue Feb 24, 2020 · 2 comments
Assignees
@Cogitri
Labels
feature

Comments

@Cogitri
Copy link
Contributor

Cogitri commented Feb 24, 2020

Hello,

it'd be nice if AssertThrows showed more information if it failed instead of just saying that it didn't get the exception it wanted. Maybe it'd be possible to test if the exception can be gotten via std::current_exception and if so get the description of that? I'd like to implement that if you're OK with that.
@sbeyer
Copy link
Member

sbeyer commented Feb 24, 2020

I would be interested in how to achieve that, so, sure, go for it 👍

Note that you can base your feature branch on the prepare-v5.0.0 branch that defaults to C++11 (which makes it easier to use std::current_exception).

@sbeyer sbeyer added the feature label Feb 24, 2020
@Cogitri
Copy link
Contributor Author

Cogitri commented Feb 24, 2020

Thanks, gonna do that :)

Cogitri added a commit to dampsoft/snowhouse that referenced this issue Feb 26, 2020
@Cogitri
If we catch the wrong exception in AssertThrows, print the descriptio…
90c9283 
…n of the exception

This makes it easier to debug the failure

fixes banditcpp#47
@Cogitri Cogitri mentioned this issue Feb 26, 2020
Merged
@sbeyer sbeyer closed this as completed in cefdde3 Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cogitri Cogitri

Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sbeyer @Cogitri