Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix [DockerVersion] service test #10690

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

jNullj
Copy link
Member

@jNullj jNullj commented Nov 22, 2024

Memcached tags don't follow semver, might fail depending on which tag was last added.
Python seems to follow semver for all tags.
docker-dev seems to follow semver and be stable as its deprecated
OK, i suggest using the deprecated image by docker docker/example-voting-app-vote and test for the 'latest' tag which is last.
Image tags for this did not change in 8 years

fixes #10689

Memcached tags don't follow semver, might fail depending on which  tag was last added.
Python seems to follow semver for all tags.
fixes badges#10689
Copy link
Contributor

github-actions bot commented Nov 22, 2024

Messages
📖 ✨ Thanks for your contribution to Shields, @jNullj!

Generated by 🚫 dangerJS against 21f45ce

its a depricated image and is not expected to change tags
tag is semver
deprecated yet by docker, i think we can count on that to be stable
@jNullj jNullj added the keep-service-tests-green Related to fixing failing tests of the services label Nov 22, 2024
@chris48s
Copy link
Member

Yeah this seems like it is probably sensible

@jNullj jNullj added this pull request to the merge queue Nov 26, 2024
Merged via the queue into badges:master with commit 60aa530 Nov 26, 2024
29 checks passed
@jNullj jNullj deleted the fix/service-test-green/docker-version branch November 26, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep-service-tests-green Related to fixing failing tests of the services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing DockerVersion test
2 participants