Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing DockerVersion test #10689

Closed
jNullj opened this issue Nov 22, 2024 · 0 comments · Fixed by #10690
Closed

Failing DockerVersion test #10689

jNullj opened this issue Nov 22, 2024 · 0 comments · Fixed by #10690
Assignees
Labels
keep-service-tests-green Related to fixing failing tests of the services

Comments

@jNullj
Copy link
Member

jNullj commented Nov 22, 2024

🕚 When did the problem start?

Here at CI

📷 Live badge

Docker Image Version
https://img.shields.io/docker/v/_/memcached

🔧 Is the live badge working?

Working, but we test for semver while values are tags and commonly don't use semver.

🐞 Stack trace

ValidationError: message mismatch: "value" needs to be a valid semver expression
    at exports.process (node_modules/joi/lib/errors.js:193:16)
    at internals.entry (node_modules/joi/lib/validator.js:250:26)
    at exports.entry (node_modules/joi/lib/validator.js:27:30)
    at internals.Base.validate (node_modules/joi/lib/base.js:548:26)
    at internals.assert (node_modules/joi/lib/index.js:225:27)
    at Object.attempt (node_modules/joi/lib/index.js:107:26)
    at IcedFrisbyNock._expectField (file:///home/runner/work/shields/shields/core/service-test-runner/icedfrisby-shields.js:89:13)
    at IcedFrisbyNock.<anonymous> (file:///home/runner/work/shields/shields/core/service-test-runner/icedfrisby-shields.js:70:26)
    at IcedFrisbyNock.<anonymous> (node_modules/icedfrisby/lib/icedfrisby.js:954:10)
    at invokeNextHook (node_modules/icedfrisby/lib/icedfrisby.js:1003:24)
    at /home/runner/work/shields/shields/node_modules/icedfrisby/lib/icedfrisby.js:1017:7
    at new Promise (<anonymous>)
    at IcedFrisbyNock._runHooks (node_modules/icedfrisby/lib/icedfrisby.js:976:12)
    at IcedFrisbyNock.run (node_modules/icedfrisby/lib/icedfrisby.js:1276:20)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async Context.<anonymous> (node_modules/icedfrisby/lib/icedfrisby.js:1348:9)

💡 Possible solution
I noticed python seems to follow only semver tags.
I think its better to change to it rather then try to write constraints for image tags that don't follow a specific ruleset.

@jNullj jNullj added the keep-service-tests-green Related to fixing failing tests of the services label Nov 22, 2024
@jNullj jNullj self-assigned this Nov 22, 2024
jNullj added a commit to jNullj/shields-fun-fork that referenced this issue Nov 22, 2024
Memcached tags don't follow semver, might fail depending on which  tag was last added.
Python seems to follow semver for all tags.
fixes badges#10689
github-merge-queue bot pushed a commit that referenced this issue Nov 26, 2024
* Update docker version tester to check Python instead of Memcached

Memcached tags don't follow semver, might fail depending on which  tag was last added.
Python seems to follow semver for all tags.
fixes #10689

* Update docker version tester to check docker-dev instead of python

its a depricated image and is not expected to change tags
tag is semver

* Update docker version tester to check example-voting-app-vote

deprecated yet by docker, i think we can count on that to be stable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep-service-tests-green Related to fixing failing tests of the services
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant