Skip to content
This repository has been archived by the owner on May 19, 2018. It is now read-only.

Change location of ObjectTypeIndexer to match flow #228

Merged
merged 1 commit into from
Jan 27, 2017
Merged

Change location of ObjectTypeIndexer to match flow #228

merged 1 commit into from
Jan 27, 2017

Conversation

danez
Copy link
Member

@danez danez commented Nov 17, 2016

Q A
Bug fix? yes
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? no
Tests added/pass? yes
Fixed tickets no
License MIT
interface Dictionary { [index: string]: string; length: number; }

http://astexplorer.net/#/TtDjoZgl57/1

The location of the ObjectTypeIndexer is currently different in flow and babylon. Babylon includes the semicolon, whereas flow does not.

Usually in all parsers for ES-Code the semicolon/colon is always included, like in ClassProperties and ObjectProperties.

So I'm not sure if we should do this, because it is not super consistent, but it would be inline with the flow parser then.

//cc @samwgoldman @gabelevi @mroch

@samwgoldman
Copy link
Contributor

We can also change the Flow parser to be consistent with Babylon. WDYT @mroch?

@danez
Copy link
Member Author

danez commented Jan 27, 2017

I'm going to merge this for 7.0. If you still want to change flow at some point I'm happy to revert it, but I think it is more important right now to be more consistent with the flow parser.

@danez danez added this to the 7.0.0 milestone Jan 27, 2017
@danez danez changed the base branch from master to 7.0 January 27, 2017 22:07
@danez danez merged commit e614032 into babel:7.0 Jan 27, 2017
@danez danez deleted the flow-loc branch January 27, 2017 22:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants