Change location of ObjectTypeIndexer to match flow (#228)

babel · Jan 27, 2017 · e614032 · e614032
1 parent c424156
commit e614032
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 9 deletions.
diff --git a/src/plugins/flow.js b/src/plugins/flow.js
@@ -282,8 +282,11 @@ pp.flowParseObjectTypeIndexer = function (node, isStatic, variance) {
   node.value = this.flowParseTypeInitialiser();
   node.variance = variance;
 
+  // Finish node first to not include a possible semicolon in the locations
+  const indexer = this.finishNode(node, "ObjectTypeIndexer");
   this.flowObjectTypeSemicolon();
-  return this.finishNode(node, "ObjectTypeIndexer");
+
+  return indexer;
 };
 
 pp.flowParseObjectTypeMethodish = function (node) {

diff --git a/test/fixtures/flow/interfaces-module-and-script/5/expected.json b/test/fixtures/flow/interfaces-module-and-script/5/expected.json
@@ -129,15 +129,15 @@
             {
               "type": "ObjectTypeIndexer",
               "start": 23,
-              "end": 47,
+              "end": 46,
               "loc": {
                 "start": {
                   "line": 1,
                   "column": 23
                 },
                 "end": {
                   "line": 1,
-                  "column": 47
+                  "column": 46
                 }
               },
               "id": {
@@ -194,4 +194,4 @@
     ]
   },
   "comments": []
-}
+}
diff --git a/test/fixtures/flow/type-annotations/41/expected.json b/test/fixtures/flow/type-annotations/41/expected.json
@@ -106,15 +106,15 @@
                     {
                       "type": "ObjectTypeIndexer",
                       "start": 9,
-                      "end": 29,
+                      "end": 28,
                       "loc": {
                         "start": {
                           "line": 1,
                           "column": 9
                         },
                         "end": {
                           "line": 1,
-                          "column": 29
+                          "column": 28
                         }
                       },
                       "id": {
@@ -167,15 +167,15 @@
                     {
                       "type": "ObjectTypeIndexer",
                       "start": 30,
-                      "end": 50,
+                      "end": 49,
                       "loc": {
                         "start": {
                           "line": 1,
                           "column": 30
                         },
                         "end": {
                           "line": 1,
-                          "column": 50
+                          "column": 49
                         }
                       },
                       "id": {
@@ -238,4 +238,4 @@
     ]
   },
   "comments": []
-}
+}