v0.3.3 changes into main #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with click (#45) * updated black version to 22.3.0 to fix compatibility issue with click 8.1.0 * updated to latest version of flake8==5.0.4 in requirement-dev.txt * updated changelog with black and flake8 fixes Co-authored-by: david hopkinson <davidhopkinson26@gmail.com>
Prefixed all errors with self.classname() call for easier debugging Added classname() method to BaseTransformer
* added prior regularisation to MeanResponseTransformer and updated tests * reworded docstring in _prior_regularisation
* Added support for weights to mean, median and mode imputer and updated tests. Added check_weights_column to BaseTransformer to facilitate validation of weights columns. * bugfix - had accidentally removed a line to iterate over columns whe adding in weights functionality. added back in. * updated changelog * added a warning to ModeImputer if mode is NaN * added missing tests to ModeImputer and MedianImputer for uniformity across test modules * changed to test_Weight_arg_errors consistent with Median and Mean imputer testing
* removed **kwargs arg from BaseTransformer.__init__ * added test for unexpected kwarg handling to test_BaseTransformer.py added similar test to example child class test module test_DataFrameMethodTransformer.py * fix broken tests with incorrect kwargs
* added DatetimeInfoExtractor transformer * added example notebook for DatetimeInfoExtractor.ipynb * changed name of transformer to DatetimeInfoExtractor from DateTimeInfoExtractor * updated test_transformers to include DatetimeInfoExtractor * updated DatetimeInfoExtractor to work with missing data * removed import sys logic from examplem notebook * added more detailed description to docstring * removed redundant type checking on columns (covered in super.__init__) * removed redundant test of column type error (covered in test_BaseTransformer) * created mappings_provided variable for easier reading * black formatting * refactored identify_timeofday, ..._timeofmonth, ..._timeofyear, ..._dayofweek into single _map_values method updated tests * updated datetime dtype error handling with more specific exception and detailed message * added detail of default values for mappings to dcostring. added more detail on default values and custom mappings requirements to examples notebook * added method description to docstring * black formatting
* added DatetimeSinusoidCalculator transformer, tests and examples
* added TwoColunOperatorMethodTransformer, tests and example notebook
* added comparison module containing EqualityChecker added test module added example notebook
* added SetColumnDtype transformer, test module and example
* StringConcatenator added to strings.py
Added PCATransformer to numeric.py Co-authored-by: Fromholz <claire.fromholz@allianz.com>
correcting broken link to changelog
* Update CHANGELOG.rst * updated api.rst with new transformers * Update quick-start.rst
TommyMatthews
approved these changes
Jan 19, 2023
davidhopkinson26
added a commit
that referenced
this pull request
Mar 15, 2023
This reverts commit 0098637.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Fixed