feature/StringConcatenator #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test module and example notebook added.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
tubular/strings.py
Outdated
|
|
||
| def transform(self, X): | ||
| """ | ||
| Concatenates values into one string. |
There was a problem hiding this comment.
Again these descriptions feel a bit vague
| "metadata": {}, | ||
| "source": [ | ||
| "# StringConcatenator\n", | ||
| "This notebook shows the functionality of the `StringConcatenator` class. This transformer joins values from different columns into a new string in a new column." |
There was a problem hiding this comment.
same again here if we're changing values here to something more specific
tubular/strings.py
Outdated
|
|
||
| class StringConcatenator(BaseTransformer): | ||
| """ | ||
| Transformer to concatenate values from a few columns into 1 string. |
There was a problem hiding this comment.
Sorry the first comment (repeated below) should have been about the "concatenate values from a few columns" in this docstring - all the others reference this with "again"
This feels a bit vague - not immediately clear that values can be any datatype, maybe:
Transform to combine data from specified columns, of mixed datatypes, into a new column containing one string?
(will this work on e.g. a column of dictionaries?)
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "# StringConcatenator\n", | ||
| "This notebook shows the functionality of the `StringConcatenator` class. This transformer joins values from different columns into a new string in a new column." | ||
| "This notebook shows the functionality of the `StringConcatenator` class. Thjis Transformer combines data from specified columns, of mixed datatypes, into a new column containing one string." |
TommyMatthews
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added transfoormer StringConcatenator to strings.py. It concatenates input coolumns into a single string output column.
Added test module and example notebook.