Adding type hints #116 #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Develop into master (0.2.15)
Version 0.3.0
Bring v0.3.1 changes into main
Bring DSF notebook into main
Interaction transformer (#38)
This reverts commit 423b14c.
-added support for prior mean encoding (regularised encodings) -added support for weights to mean, median and mode imputers -added classname() method to BaseTransformer and prefixed all errors with classname call for easier debugging -added DatetimeInfoExtractor transformer -added DatetimeSinusoidCalculator -added TwoColumnOperatorTransformer -added StringConcatenator -added SetColumnDtype -added waring to MappingTransformer for unexpected changes in dtype -added new module tubular/comparison.py containing EqualityChecker -added PCATransformer -updated black version to 22.3.0 and flake8 version to 5.0.4 to fix compatibility issues -removed kwargs argument from BaseTransfomer -updated version to 0.3.3 -updated changelog and docs Co-authored-by: Claire_Fromholz <33227678+ClaireF57@users.noreply.github.com> Co-authored-by: Fromholz <claire.fromholz@allianz.com>
This reverts commit 0098637.
Revert "v0.3.3 changes into main"
0.3.4 changes into main (also merges changes for 0.3.3 after reversion)
merge changes for 0.3.5
Merge changes for 0.3.6
Update _version.py to 0.3.6
0.3.7 changes into main
Version update into main
0.3.8 changes into main
#99 into main
|
Looking at ANN03 - type hinting kwargs - this is quite difficult to implement in general, and tubular in general does not have many params passed through as kwargs - unsure how to proceed with these |
V1.0.0 changes into main
now passing all ANN bar 101 and 003
now passing all bar ANN101 and 003
V 1.1.0 changes into main
…this is less confusing.
# Conflicts: # tubular/base.py # tubular/nominal.py
…rittle test that inspects 'implementation not behaviour' adapted (reference to #155)
A really solid bit of work here - thanks for the hard work all! |
… does not advertise that type
…lumn_name is left empty
…lumn_name is left empty
adamsardar
reviewed
Dec 29, 2023
adamsardar
approved these changes
Dec 29, 2023
There was a problem hiding this comment.
Looking good!
I'm going to approve and merge because:
- I've just swooped in at the end to get it over the line
- Sarah wrote this, Tommy has reviewed, Dave has commented. I think that it's had all the eyeballs that it's going to get!
- Coffee is for (branch) closers. Always Be Closing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working through the repo to add in type hints across the code base in order to address ANN ruff rules:
ANN001: missing-type-function-argument - Missing type annotation for function argument
ANN002: missing-type-args - Missing type annotation for *{name}
ANN003: missing-type-kwargs - Missing type annotation for **{name}
ANN101: missing-type-self - Missing type annotation for {name} in method
ANN102: missing-type-cls - Missing type annotation for {name} in classmethod
ANN201: missing-return-type-undocumented-public-function - Missing return type annotation for public function {name}
ANN202: missing-return-type-private-function - Missing return type annotation for private function {name}
ANN204: missing-return-type-special-method - Missing return type annotation for special method {name}
ANN205: missing-return-type-static-method - Missing return type annotation for staticmethod {name}
ANN206: missing-return-type-class-method - Missing return type annotation for classmethod {name}
ANN401: any-type - Dynamically typed expressions (typing.Any) are disallowed in {name}
Notes:
I'd suggest we exclude ANN101 as it adds clutter without much information, and as ruff put it "Note that many type checkers will infer the type of self automatically, so this annotation is not strictly necessary."