-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR change pass. #704
PR change pass. #704
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## grand_dispatch_queue #704 +/- ##
========================================================
- Coverage 79.69% 79.59% -0.11%
========================================================
Files 30 30
Lines 6117 6126 +9
========================================================
+ Hits 4875 4876 +1
- Misses 1242 1250 +8 ☔ View full report in Codecov by Sentry. |
…cess of being destroyed
aws_mutex_init(&dispatch_loop->synced_data.synced_data_lock); | ||
|
||
/* The dispatch queue is suspended at this point. */ | ||
dispatch_loop->synced_data.suspended = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be necessary as we already called dispatch_suspend(dispatch_loop->dispatch_queue);
above.
struct dispatch_loop_context *dispatch_queue_context = entry->dispatch_queue_context; | ||
s_release_dispatch_loop_context(dispatch_queue_context); | ||
|
||
/* Cleans up a `scheduled_iteration_entry` */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably wanna clarify that the destroy function will only release the memory of the entry. The caller should make sure to remove the priority_queue_node
from its queue.
Changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.