A bunch of CMake fixes #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpatible with latest versions too
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #701 +/- ##
=======================================
Coverage 79.69% 79.69%
=======================================
Files 30 30
Lines 6117 6117
=======================================
Hits 4875 4875
Misses 1242 1242 ☔ View full report in Codecov by Sentry. |
sfod
approved these changes
Jan 24, 2025
debasishbsws
added a commit
to wolfi-dev/os
that referenced
this pull request
Jan 29, 2025
…up dev package - Set BUILD_TESTING=OFF to disable testing - Use Melange standard cmake pipelines for configure, build, and install - Remove manual handling of aws-c-io dev folder as it is now handled upstream (see: awslabs/aws-c-io#701) Signed-off-by: Debasish Biswas <debasishbsws.dev@gmail.com>
OddBloke
pushed a commit
to wolfi-dev/os
that referenced
this pull request
Jan 29, 2025
…up dev package - Set BUILD_TESTING=OFF to disable testing - Use Melange standard cmake pipelines for configure, build, and install - Remove manual handling of aws-c-io dev folder as it is now handled upstream (see: awslabs/aws-c-io#701) Signed-off-by: Debasish Biswas <debasishbsws.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: awslabs/aws-c-common#1178
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.