-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement Serializable for ThresholdedRandomCutForestState #298
Conversation
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Per the recommendation in the Javadocs for Serializable, we should explicitly define the |
Can we create an example based on the existing serialization examples that serializes and deserializes a forest and validates that the deserialized forest produces outputs that are consistent with the original forest? |
Thanks, will add. BTW, will evaluate other serialization lib later and may change the serialization way in MLCommons. Currently use ObjectOutputStream is mainly to keep consistent with current code and save effort to unblock some work. |
Sure, will add |
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Can anyone help take a look and approve if no more comments? @jotok @sudiptoguha |
Ran
|
* implement Serializable for ThresholdedRandomCutForestState Signed-off-by: Yaliang Wu <ylwu@amazon.com> * add serialVersionUID and example Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Yaliang Wu ylwu@amazon.com
#297
Description of changes:
implement Serializable for ThresholdedRandomCutForestState
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.