Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Serializable to support serialization via ObjectOutputStream #297

Closed
ylwu-amzn opened this issue Feb 11, 2022 · 0 comments
Closed

Comments

@ylwu-amzn
Copy link
Contributor

Currently MLCommons is using ObjectOutputStream to serialize object (code link). But ThresholdedRandomCutForestState doesn't implement Serializable, so it's impossible to serialize via ObjectOutputStream.

AD is using protostuff to serialize. protostuff has one bug reported in AD opensearch-project/anomaly-detection#263, we fixed by adding local jar dependency as protostuff team has no clear plan to release new version.

If we use same way in MLCommons we need to add one more dependency and we need to maintain two serialization ways. So prefer to implement Serializable to make serialization easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant