Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: select OS in ODCR scheduling tests #7802

Merged
merged 1 commit into from
Feb 26, 2025
Merged

test: select OS in ODCR scheduling tests #7802

merged 1 commit into from
Feb 26, 2025

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Feb 26, 2025

Fixes #N/A

Description
Updates the NodePool requirements in the ODCR scheduling E2E test suite to select linux for the OS. This prevents Karpenter from attempting to schedule a Windows only daemonset, which results in no compatible instances.

How was this change tested?
make e2etest

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner February 26, 2025 19:25
@jmdeal jmdeal requested a review from engedaam February 26, 2025 19:25
@jmdeal jmdeal force-pushed the fix/scheduling-odcr-reqs branch from 3a7a44c to 2bf1f68 Compare February 26, 2025 19:25
@netlify Netlify
Copy link

netlify bot commented Feb 26, 2025 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 3a7a44c
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/67bf6ab0f8657100083f93b8

@jmdeal jmdeal changed the title fix: select OS in ODCR scheduling tests test: select OS in ODCR scheduling tests Feb 26, 2025
@jmdeal jmdeal enabled auto-merge (squash) February 26, 2025 19:27
@netlify Netlify
Copy link

netlify bot commented Feb 26, 2025 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 2bf1f68
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/67bf6ac2a1ff55000889478b

engedaam
engedaam approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal merged commit a91eeb7 into aws:main Feb 26, 2025
18 checks passed
@coveralls
Copy link

coveralls commented Feb 26, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13551805607

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 66.801%
Totals Coverage Status
Change from base Build 13548371117: 0.03%
Covered Lines: 6642
Relevant Lines: 9943
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engedaam engedaam engedaam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmdeal @coveralls @engedaam