test: select OS in ODCR scheduling tests (#7802)

aws · Feb 26, 2025 · a91eeb7 · a91eeb7
1 parent 059d85e
commit a91eeb7
Showing 1 changed file with 19 additions and 5 deletions.
diff --git a/test/suites/scheduling/suite_test.go b/test/suites/scheduling/suite_test.go
@@ -741,13 +741,27 @@ var _ = Describe("Scheduling", Ordered, ContinueOnFailure, func() {
 					ID: xlargeCapacityReservationID,
 				},
 			}
-			nodePool.Spec.Template.Spec.Requirements = []karpv1.NodeSelectorRequirementWithMinValues{{NodeSelectorRequirement: corev1.NodeSelectorRequirement{
-				Key:      karpv1.CapacityTypeLabelKey,
-				Operator: corev1.NodeSelectorOpIn,
-				Values:   []string{karpv1.CapacityTypeOnDemand, karpv1.CapacityTypeReserved},
-			}}}
+			nodePool.Spec.Template.Spec.Requirements = []karpv1.NodeSelectorRequirementWithMinValues{
+				{
+					NodeSelectorRequirement: corev1.NodeSelectorRequirement{
+						Key:      karpv1.CapacityTypeLabelKey,
+						Operator: corev1.NodeSelectorOpIn,
+						Values:   []string{karpv1.CapacityTypeOnDemand, karpv1.CapacityTypeReserved},
+					},
+				},
+				// We need to specify the OS label to prevent a daemonset with a Windows specific resource from scheduling against
+				// the node. Omitting this requirement will result in scheduling failures.
+				{
+					NodeSelectorRequirement: corev1.NodeSelectorRequirement{
+						Key:      corev1.LabelOSStable,
+						Operator: corev1.NodeSelectorOpIn,
+						Values:   []string{string(corev1.Linux)},
+					},
+				},
+			}
 		})
 		It("should schedule against a specific reservation ID", func() {
+			selectors.Insert(v1.LabelCapacityReservationID)
 			pod := test.Pod(test.PodOptions{
 				NodeRequirements: []corev1.NodeSelectorRequirement{{
 					Key:      v1.LabelCapacityReservationID,