Fix Automatic-Module-Names to use dots instead of dashes (not allowed… #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 4, 2021
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
============================================
- Coverage 58.86% 58.84% -0.02%
+ Complexity 1202 1201 -1
============================================
Files 131 131
Lines 5061 5061
Branches 590 590
============================================
- Hits 2979 2978 -1
Misses 1807 1807
- Partials 275 276 +1
Continue to review full report at Codecov.
|
|
Closing in favor of #297 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… by JPMS).
Issue #, if available:
Description of changes:
I made a mistake in #295 - dashes are not allowed in module names. This PR uses dots instead. I also opened #297 which uses underscores - I'll leave the choice up to the maintainers :).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.