Add Automatic-Module-Name to jar manifest. Fixes #292. #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willarmiros
approved these changes
Aug 3, 2021
|
I may have made a mistake here. I think that the module names should not have dashes. Instead of |
|
@willarmiros Yes - I did make a mistake. JPMS does not allow dashes in module names. Should we use dots as above or perhaps underscores would be more appropriate? |
This was referenced Aug 4, 2021
|
IMO Underscores are better so as not to confuse the dots with package delimiters. Do you agree @anuraaga? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#292
Description of changes:
Configures the gradle JAR plugin to add an
Automatic-Module-Nameentry to the manifest for each project. This allows for using aws-xray-sdk-java in a modular Java project.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.