Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add retry in smoke test #288

Merged
merged 3 commits into from
Jun 23, 2021
Merged

add retry in smoke test #288

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e381b5
add retry in smoke test
wangzlei Jun 16, 2021
6ac23b1
add retry by shell
wangzlei Jun 22, 2021
6f3729e
add retry by shell
wangzlei Jun 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/continuous-monitoring.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,11 @@ jobs:

- name: Run smoke tests
id: distribution-availability
run: ./gradlew :smoke-tests:check -PtestDistributionChannel=true
uses: nick-invision/retry@v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should avoid random third party actions if possible, especially in a distribution channel monitor. I think we can update the cache action to cache dependencies as well instead

Copy link
Contributor Author

@wangzlei wangzlei Jun 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github action may occur downloading failure in anywhere, not only gradle.zip, if we cannot predict which part would get failure it is hard to add cache, now we just see an error then add cache on it. Also, adding more cache will inflate CI/CD code.

When we testing if the target binary/dependency is available, say xray-java-sdk in this case, we cannot add cache for it. Retry might be the only way to mitigate false download failure.

with:
timeout_seconds: 180
max_attempts: 3
command: ./gradlew :smoke-tests:check -PtestDistributionChannel=true

- name: Publish metric on X-Ray Java SDK distribution availability
if: ${{ always() }}
Expand Down