add retry in smoke test #288
Conversation
|
aws-otel-lambda canary failure has been solved by adding retry |
| @@ -32,7 +32,11 @@ jobs: | |||
|
|
|||
| - name: Run smoke tests | |||
| id: distribution-availability | |||
| run: ./gradlew :smoke-tests:check -PtestDistributionChannel=true | |||
| uses: nick-invision/retry@v2 | |||
There was a problem hiding this comment.
We should avoid random third party actions if possible, especially in a distribution channel monitor. I think we can update the cache action to cache dependencies as well instead
There was a problem hiding this comment.
Github action may occur downloading failure in anywhere, not only gradle.zip, if we cannot predict which part would get failure it is hard to add cache, now we just see an error then add cache on it. Also, adding more cache will inflate CI/CD code.
When we testing if the target binary/dependency is available, say xray-java-sdk in this case, we cannot add cache for it. Retry might be the only way to mitigate false download failure.
| (echo "===== Attempt: 1 ====" && ./gradlew :smoke-tests:check -PtestDistributionChannel=true) || \ | ||
| (echo "===== Attempt: 2 ====" && ./gradlew :smoke-tests:check -PtestDistributionChannel=true) || \ | ||
| (echo "===== Attempt: 3 ====" && ./gradlew :smoke-tests:check -PtestDistributionChannel=true) || \ | ||
| (echo "===== Failed ====" && exit 1) |
There was a problem hiding this comment.
| (echo "===== Failed ====" && exit 1) | |
| (echo "===== No more retries. Failed. ====" && exit 1) |
Codecov Report
@@ Coverage Diff @@
## master #288 +/- ##
============================================
- Coverage 58.92% 58.86% -0.06%
Complexity 1202 1202
============================================
Files 131 131
Lines 5056 5056
Branches 588 588
============================================
- Hits 2979 2976 -3
- Misses 1804 1807 +3
Partials 273 273
Continue to review full report at Codecov.
|
Issue #, if available:
Github action might have random dependency downloading failure. Add retry to reduce false alarmm
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.