Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[integ-test] Fix test_cli_commands in iso regions #6643

Merged
merged 1 commit into from
Jan 21, 2025
Merged

[integ-test] Fix test_cli_commands in iso regions #6643

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/integration-tests/tests/cli_commands/test_cli_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def test_slurm_cli_commands(
# Use long scale down idle time so we know nodes are terminated by pcluster stop
cluster_config = pcluster_config_reader(scaledown_idletime=60)

if "alinux" not in os and "us-iso" in region: # The code does not know non-amazon vanilla AMIs IDs in iso regions
if "alinux" in os or "us-iso" not in region: # The code does not know non-amazon vanilla AMIs IDs in iso regions
# Using custom AMI not tagged by pcluser will generate a warning
custom_ami = retrieve_latest_ami(region, os, ami_type="official", architecture="x86_64")
config_file = "pcluster.config.with.warnings.yaml"
Expand All @@ -59,7 +59,7 @@ def test_slurm_cli_commands(
_test_describe_cluster(cluster)
_test_list_cluster(cluster.name, "CREATE_COMPLETE")

if "alinux" not in os and "us-iso" in region:
if "alinux" in os or "us-iso" not in region:
_test_update_with_warnings(cluster_config_with_warning, cluster)
check_status(cluster, "CREATE_COMPLETE", "running", "RUNNING")

Expand Down
Loading