Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[integ-test] Fix test_cli_commands in iso regions #6643

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

hanwen-cluster
Copy link
Contributor

This commit fixes a bug from 7323fae

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This commit fixes a bug from aws@7323fae

Signed-off-by: Hanwen <hanwenli@amazon.com>
@hanwen-cluster hanwen-cluster requested review from a team as code owners January 21, 2025 20:02
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.20%. Comparing base (8f86b20) to head (c98825d).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6643   +/-   ##
========================================
  Coverage    90.20%   90.20%           
========================================
  Files          181      181           
  Lines        16218    16218           
========================================
  Hits         14630    14630           
  Misses        1588     1588           
Flag Coverage Δ
unittests 90.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hanwen-cluster hanwen-cluster added the skip-changelog-update Disables the check that enforces changelog updates in PRs label Jan 21, 2025
@hanwen-cluster hanwen-cluster merged commit 704b811 into aws:develop Jan 21, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog-update Disables the check that enforces changelog updates in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants