Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cloudtrail): Invalid arn partition for GovCloud #8248

Merged
merged 4 commits into from
Jun 14, 2020
Merged

fix(cloudtrail): Invalid arn partition for GovCloud #8248

merged 4 commits into from
Jun 14, 2020

Conversation

cmckni3
Copy link
Contributor

@cmckni3 cmckni3 commented May 27, 2020 •
edited by SomayaB
Loading

Use partition ref for lambda and s3 data events

Closes #8247

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 3d7641d
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@cmckni3 cmckni3 mentioned this pull request Jun 1, 2020
Closed
eladb
eladb suggested changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update PR title to reflect the bug (what’s not working)

eladb
eladb previously requested changes Jun 2, 2020
View reviewed changes
@eladb eladb assigned eladb and unassigned rix0rrr Jun 2, 2020
@cmckni3 cmckni3 changed the title fix(cloudtrail): Use partition ref fix(cloudtrail): Invalid arn partition for GovCloud Jun 2, 2020
@mergify mergify bot dismissed eladb’s stale review June 2, 2020 18:18

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 2aef257
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@cmckni3 cmckni3 mentioned this pull request Jun 2, 2020
Merged
eladb
eladb suggested changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect some tests to break

@cmckni3
Copy link
Contributor Author

cmckni3 commented Jun 4, 2020

@eladb should I update tests? I can run the tests locally to see.

eladb
eladb previously requested changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eladb should I update tests? I can run the tests locally to see.

Yes, please see the contribution guide for details on how to re-run the integration test

@mergify mergify bot dismissed eladb’s stale review June 11, 2020 16:03

Pull request has been modified.

@cmckni3
Copy link
Contributor Author

cmckni3 commented Jun 11, 2020 •
edited
Loading

Yes, please see the contribution guide for details on how to re-run the integration test

I don't see integration tests for logAllS3DataEvents and logAllLambdaDataEvents

I have updated the cloudtrail.test.ts file (unit tests I believe). They pass for me but there is an unrelated failure from a previous commit on master.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: b1fd1ac
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 2b2c17b
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 071d9b0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jun 14, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 5b3d87c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jun 14, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5189170 into aws:master Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

Assignees

@eladb eladb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cloudtrail: Construct does not account for partitions
4 participants
@cmckni3 @aws-cdk-automation @eladb @rix0rrr