Skip to content

Commit

Permalink
fix(cloudtrail): Use partition ref
Browse files Browse the repository at this point in the history
Use partition ref for lambda and s3 data events

#8247
  • Loading branch information
cmckni3 authored May 27, 2020
1 parent 9a54447 commit 3d7641d
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions packages/@aws-cdk/aws-cloudtrail/lib/cloudtrail.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import * as lambda from '@aws-cdk/aws-lambda';
import * as logs from '@aws-cdk/aws-logs';
import * as s3 from '@aws-cdk/aws-s3';
import * as sns from '@aws-cdk/aws-sns';
import { Construct, Resource, Stack } from '@aws-cdk/core';
import { Construct, Fn, Resource, Stack } from '@aws-cdk/core';
import { CfnTrail } from './cloudtrail.generated';

/**
Expand Down Expand Up @@ -333,7 +333,7 @@ export class Trail extends Resource {
* @default false
*/
public logAllLambdaDataEvents(options: AddEventSelectorOptions = {}) {
return this.addEventSelector(DataResourceType.LAMBDA_FUNCTION, [ 'arn:aws:lambda' ], options);
return this.addEventSelector(DataResourceType.LAMBDA_FUNCTION, [ `arn:${Fn.ref('AWS::Partition')}:lambda` ], options);
}

/**
Expand All @@ -360,7 +360,7 @@ export class Trail extends Resource {
* @default false
*/
public logAllS3DataEvents(options: AddEventSelectorOptions = {}) {
return this.addEventSelector(DataResourceType.S3_OBJECT, [ 'arn:aws:s3:::' ], options);
return this.addEventSelector(DataResourceType.S3_OBJECT, [ `arn:${Fn.ref('AWS::Partition')}:s3:::` ], options);
}

/**
Expand Down

0 comments on commit 3d7641d

Please sign in to comment.