Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-iam): generate warning when using addManagedPolicy on an imported Role #15766

Closed
wants to merge 2 commits into from
Closed

fix(aws-iam): generate warning when using addManagedPolicy on an imported Role #15766

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ac8a3b
Generate warning on Role.addManagedPolicy
gshpychka Jul 26, 2021
57c945d
Fixed warning wording
gshpychka Jul 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/@aws-cdk/aws-iam/lib/role.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Duration, Resource, Stack, Token, TokenComparison } from '@aws-cdk/core';
import { Annotations, Duration, Resource, Stack, Token, TokenComparison } from '@aws-cdk/core';
import { Construct, Node } from 'constructs';
import { Grant } from './grant';
import { CfnRole } from './iam.generated';
Expand Down Expand Up @@ -234,7 +234,7 @@ export class Role extends Resource implements IRole {
}

public addManagedPolicy(_policy: IManagedPolicy): void {
// FIXME: Add warning that we're ignoring this
Annotations.of(this).addWarning('@aws-cdk/aws-iam.Role.addManagedPolicy() is not supported for imported roles at this time. Use @aws-cdk/aws-iam.ManagedPolicy.attachToRole()');
}

/**
Expand Down Expand Up @@ -540,4 +540,4 @@ export interface WithoutPolicyUpdatesOptions {
* @default false
*/
readonly addGrantsToResources?: boolean;
}
}