Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-iam): generate warning when using addManagedPolicy on an imported Role #15766

Closed
wants to merge 2 commits into from

Conversation

gshpychka
Copy link
Contributor

Related issue:
#8307

@gitpod-io
Copy link

gitpod-io bot commented Jul 26, 2021

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 57c945d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@gshpychka
Copy link
Contributor Author

Please advise the proper way to test warning generation.

@peterwoodworth peterwoodworth added the @aws-cdk/aws-iam Related to AWS Identity and Access Management label Jul 28, 2021
@gshpychka
Copy link
Contributor Author

@rix0rrr Not sure how to proceed - please advise

@nija-at nija-at added effort/small Small work item – less than a day of effort p2 labels Aug 5, 2021
@gshpychka
Copy link
Contributor Author

@nija-at what do I have to do to have this merged?

@TheRealAmazonKendra
Copy link
Contributor

@gshpychka Thank you for making this change. A test for this would be something along the lines of:

Annotations.fromStack(stack).hasWarning('/Path/To/Node', 'warning message');

@github-actions
Copy link

This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@github-actions
Copy link

github-actions bot commented May 5, 2022

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@github-actions github-actions bot added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label May 5, 2022
@github-actions github-actions bot closed this May 5, 2022
@miekassu
Copy link

miekassu commented Dec 1, 2022

This is still an issue

@Lanayx
Copy link

Lanayx commented Jul 24, 2023

For some reason this warning is not properly displayed in console I only see the following

[Warning at /CdktestStack/myRoleId] [object Object]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-iam Related to AWS Identity and Access Management closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants