feat(stepfunctions-tasks): adding on demand option + allocation s… #12512

mohanrajendran · 2021-01-14T18:13:20Z

…trategy for emrcreatecluster step

The current InstanceFleetProvisioningSpecificationsProperty (https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-stepfunctions-tasks.EmrCreateCluster.InstanceFleetProvisioningSpecificationsProperty.html) only supports spot specification whereas the EMR InstanceFleetProvisioningSpecifications supports OnDemandSpecification (https://docs.aws.amazon.com/emr/latest/APIReference/API_InstanceFleetProvisioningSpecifications.html#EMR-Type-InstanceFleetProvisioningSpecifications-OnDemandSpecification). This commit adds the missing options.

fixes #12501

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…trategy for emrcreatecluster step The current InstanceFleetProvisioningSpecificationsProperty (https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-stepfunctions-tasks.EmrCreateCluster.InstanceFleetProvisioningSpecificationsProperty.html) only supports spot specification whereas the EMR InstanceFleetProvisioningSpecifications supports OnDemandSpecification (https://docs.aws.amazon.com/emr/latest/APIReference/API_InstanceFleetProvisioningSpecifications.html#EMR-Type-InstanceFleetProvisioningSpecifications-OnDemandSpecification). This commit adds the missing options. fixes aws#12501

gitpod-io · 2021-01-14T18:13:23Z

packages/@aws-cdk/aws-stepfunctions-tasks/lib/emr/emr-create-cluster.ts

shivlaks · 2021-01-14T18:30:55Z

packages/@aws-cdk/aws-stepfunctions-tasks/lib/emr/emr-create-cluster.ts

+   *
+   * @experimental
+   */
+  export interface OnDemandProvisioningSpecificationProperty {


naming, we generally use Props as a suffix for constructs and Options as a suffix otherwise.
maybe this should be called OnDemandProvisioningOptions or something simpler.

It was a miss and something we should clean up when we drop the experimental for the already existing SpotProvisioningSpecificationProperty interface. But let's not proliferate it further 🙂

I have followed existing conventions of using Property throughout. I think changing this to Props would require changing existing names to Props as well and that would introduce a breaking change.

As for the experimental annotation, its used all over this file, is it fine to remove them all?

sure, let's leave it alone for now. i'm not a fan of proliferating something we know we want to change because that's the way it's always been done.

but i'm happy to do it in another change. it will break more things, but that's the only way to stop the trend.

shivlaks · 2021-01-14T18:33:59Z

packages/@aws-cdk/aws-stepfunctions-tasks/lib/emr/private/cluster-utils.ts

+/**
+ * Render the SpotProvisioningSpecificationProperty to JSON
+ *
+ * @param property
+ */
+export function SpotProvisioningSpecificationPropertyToJson(property: EmrCreateCluster.SpotProvisioningSpecificationProperty) {
+  return {
+    AllocationStrategy: cdk.stringToCloudFormation(property.allocationStrategy),
+    BlockDurationMinutes: cdk.numberToCloudFormation(property.blockDurationMinutes),
+    TimeoutAction: cdk.stringToCloudFormation(property.timeoutAction?.valueOf()),
+    TimeoutDurationMinutes: cdk.numberToCloudFormation(property.timeoutDurationMinutes),
+  };
+}


this is only used in one location from what I can tell, does it need to be in a shared utils file?
let's avoid future proofing until the need arises.

I could see all the conversion functions are in the utils file. Do you have a suggestion on how we can break them up?

shivlaks · 2021-01-14T18:34:45Z

packages/@aws-cdk/aws-stepfunctions-tasks/lib/emr/private/cluster-utils.ts

+/**
+ * Render the SpotProvisioningSpecificationProperty to JSON
+ *
+ * @param property
+ */
+export function OnDemandProvisioningSpecificationPropertyToJson(property: EmrCreateCluster.OnDemandProvisioningSpecificationProperty) {
+  return {
+    AllocationStrategy: cdk.stringToCloudFormation(property.allocationStrategy),
+  };
+}
+


does this need to be exported? it's only used locally within this file

I have also followed convention here all the functions in cluster-utils.ts are exported.

shivlaks · 2021-01-14T18:36:06Z

packages/@aws-cdk/aws-stepfunctions-tasks/lib/emr/private/cluster-utils.ts

+    SpotSpecification:
+      property.spotSpecification === undefined
+        ? property.spotSpecification
+        : SpotProvisioningSpecificationPropertyToJson(property.spotSpecification),


Suggested change

SpotSpecification:

property.spotSpecification === undefined

? property.spotSpecification

: SpotProvisioningSpecificationPropertyToJson(property.spotSpecification),

SpotSpecification: property?.spotSpecification ?? SpotProvisioningSpecificationPropertyToJson(property.spotSpecification,

This would be wrong, we don't want to convert to JSON if the field is undefined.

shouldn't the function handle that?

shivlaks · 2021-01-14T18:36:54Z

packages/@aws-cdk/aws-stepfunctions-tasks/lib/emr/private/cluster-utils.ts

+    OnDemandSpecification:
+      property.onDemandSpecification === undefined
+        ? property.onDemandSpecification
+        : OnDemandProvisioningSpecificationPropertyToJson(property.onDemandSpecification),


Suggested change

OnDemandSpecification:

property.onDemandSpecification === undefined

? property.onDemandSpecification

: OnDemandProvisioningSpecificationPropertyToJson(property.onDemandSpecification),

OnDemandSpecification: property?.onDemandSpecification ?? OnDemandProvisioningSpecificationPropertyToJson(property.onDemandSpecification),

Same as above.

same question about the function. can it be more robust to return undefined if the property is undefined?

packages/@aws-cdk/aws-stepfunctions-tasks/lib/emr/emr-create-cluster.ts

shivlaks · 2021-01-15T17:57:41Z

packages/@aws-cdk/aws-stepfunctions-tasks/lib/emr/emr-create-cluster.ts

  }

+


nit: remove extra line

…ws#12508) Bumps [typescript-json-schema](https://github.com/YousefED/typescript-json-schema) from 0.46.0 to 0.47.0. - [Release notes](https://github.com/YousefED/typescript-json-schema/releases) - [Commits](YousefED/typescript-json-schema@v0.46.0...v0.47.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

…cts (aws#12504) Introduce an eslint rule & fix all instances in our code which refer to `@aws-cdk/core.Construct` using a qualified namespace (e.g. `core.Construct`, `cdk.Construct`, etc). In v2, `Construct` will refer to `constructs.Construct` so it will reduce the chances for merge issues. The rule fixer automatically adds an `import` statement (separated from the main import group) and replaces the usage. If the file already imports `constructs.Construct`, then the new import will alias as `CoreConstruct`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.827.0 to 2.828.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-js@v2.827.0...v2.828.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

) This is the current active LTS version and is a good minimum requirement. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

…ion (aws#12509) The script currently does not support publishing CDKv2. Update the script so as to read the baseline version by resolving the version from the repo's current state (from `resolve-version.js`). If the resolved version is not present in NPM, usually because the version is not *yet* published, fallback to an environment variable `NPM_DISTTAG` that specifies the dist tag to use. ref: aws/cdk-ops#1151 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

…aws#12272) Closes aws#12256 Clarified the usage of custom user data with default or custom AMI by adding another example and pointing out the differences. Changed the launch template reference in the examples to use the latest version rather than the default. If you don't know the difference it would be unexpected for the user to change the user data without having it applied to the nodes after deploy. Removed unnecessary wrapping of instance type string with typed version and calling toString. Make the sentence about defining instance type either in launch template or node group more understandable. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

We were missing a few cases where we did not validate that a package had the correct `maturity` set: - A package with L2s could still have a `maturity` of 'cfn-only' - A package with only L1s could still have a non-'cfn-only' `maturity` Fix that in the linter, along with the violations discovered. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

…ws#12539) Relates to aws#12478 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

We've moved off the npm client and onto yarn a long time ago. These scripts are still using the npm client. Instead switch them to use the `yarn` command. No substantial difference, just consistency. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

aws#12527) Oversight, the README currently refers to the [lambda-layer-awscli](https://github.com/aws/aws-cdk/tree/master/packages/%40aws-cdk/lambda-layer-awscli) module. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

ElasticSearch-support for UltraWarm nodes including validations for necessary pre-requirements. Closes aws#6462. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Bumps [esbuild](https://github.com/evanw/esbuild) from 0.8.32 to 0.8.33. - [Release notes](https://github.com/evanw/esbuild/releases) - [Changelog](https://github.com/evanw/esbuild/blob/master/CHANGELOG.md) - [Commits](evanw/esbuild@v0.8.32...v0.8.33) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

…3.0 (aws#12561) Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 4.12.0 to 4.13.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.13.0/packages/eslint-plugin) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

Many people don't commit or want to commit `cdk.context.json`, and are subsequently annoyed that they can't use `Vpc.fromLookup()` in a pipeline. Make it very clear that this is the way CDK is designed to work and they must do it. Relates to aws#12160 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 10.17.48 to 10.17.51. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

Closes aws#12381 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

aws#11479) (aws#12549) closes aws#11479 ---- Hello, picking this up as my first issue to learn about how CDK works: [AWS mentions](https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_elements_principal.html) that iam groups can't be principals in policies. If a developer doesn't know this, they get an error during deployment. This change will throw an error to help them catch the issue during synthesis time. Note that this doesn't handle the code path where an arn string is specified as the principal, but the method already documents that a group would be invalid. Let me know if there's a cleaner way to fix this.

) Bumps [@types/lodash](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/lodash) from 4.14.167 to 4.14.168. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/lodash) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

…4.0 (aws#12581) Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 4.13.0 to 4.14.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.14.0/packages/eslint-plugin) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

…ric (aws#12455) Adds the missing predefined metric for MSK storage auto scaling. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

…aws#12558) Add `codeBuildCloneOutput` property to the CodeCommit source action. It automatically adds the `codecommit:GetRepository` permission to the CodeCommitSourceAction role. It will also add the `codecommit:GitPull` permission to any CodeBuildAction using the artifact from CodeCommitSourceAction as input. Closes aws#12236 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Bumps [esbuild](https://github.com/evanw/esbuild) from 0.8.33 to 0.8.34. - [Release notes](https://github.com/evanw/esbuild/releases) - [Changelog](https://github.com/evanw/esbuild/blob/master/CHANGELOG.md) - [Commits](evanw/esbuild@v0.8.33...v0.8.34) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

`Data` -> `JsonPath` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

…instead of ARN (aws#12436) feat(stepfunctions-tasks): EcsRunTask now uses taskDefinition family instead of ARN Currently the ECS run task implementation uses full ARN of the task definition. This ARN contains the ACTIVE revision at the end. The ACTIVE revision keeps on changing as the task definition changes causing potential failures (refer the issue). This change now lets the run task API to use task definition family (and corresponding ARN which does not contain the revision) to run the task. Using the family would mean that the latest ACTIVE revision of task-definition is used always. This is supported out of the box by ECS (refer the below refs). Parameter Ref: https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_RunTask.html#ECS-RunTask-request-taskDefinition Permissions Ref: https://docs.aws.amazon.com/step-functions/latest/dg/ecs-iam.html closes aws#12080 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

In aws#12394, the ability was added to read context from the CDK config file in the user home directory. However, this interferes with the unit tests which expect a pristine config, so the unit tests fail on a machine with a `~/.cdk.json` file that has context. Fix that. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

…ute (aws#12528) Currently when we define any HTTP integration (like ALB, NLB etc.) explicitly and use it for multiple routes, the `HttpRoute` construct will create a new `HttpIntegration` resource for each of these routes. [Ref](https://github.com/aws/aws-cdk/blob/master/packages/%40aws-cdk/aws-apigatewayv2/lib/http/route.ts#L128) These extra HttpIntegration (and hence `CfnIntegration`) are not required since the same integration can be used for all the routes. This feature is supported in console as well (i.e. selecting same integration for multiple routes). A sample snippet: ```ts const apiGateway = new apigw.HttpApi(this, apiLableApiGateway); const apiIntegration = new apigwint.HttpAlbIntegration({ listener : apiListener, vpcLink : apiVpcLink }); const apiRoutes = [ { method: apigw.HttpMethod.ANY, path: '/' }, { method: apigw.HttpMethod.GET, path: '/status' }, { method: apigw.HttpMethod.GET, path: '/whateverelse' }, ]; for (const apiRouteIndex in apiRoutes) { const apiRouteMethod = apiRoutes[apiRouteIndex].method; const apiRoutePath = apiRoutes[apiRouteIndex].path; apiGateway.addRoutes({ methods : [apiRouteMethod], path : apiRoutePath, integration : apiIntegration, }); } ``` The root cause of this issue is that the current api resource does not keep track of any existing integrations with the same integration config. We are solving this issue by keeping track of these integrations in an internal map with key as stringified value of `HttpRouteIntegrationConfig` (which we get by calling the `bind` function) and value as the `HttpIntegration`. This ensures that we reuse any existing integration (with same config) instead of creating a new one for every route. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

…12652) This is in order to minimize the merge conflicts with the `v2-main` branch, where we will deprecate the `@aws-cdk/assets` module. Unfortunately, we can't deprecate this module on the main V1 branch, as the [`CopyOptions` struct](https://github.com/aws/aws-cdk/blob/d169688f35bc78c88c44ff9a7d8fa0dfea71f904/packages/%40aws-cdk/assets/lib/fs/options.ts#L8-L14) inside of it is incompatible with the non-deprecated version in `@aws-cdk/core`, [also called `CopyOptions`](https://github.com/aws/aws-cdk/blob/d169688f35bc78c88c44ff9a7d8fa0dfea71f904/packages/%40aws-cdk/core/lib/fs/options.ts#L64-L70) - the `follow` property has different types in the two modules, and the `CopyOptions` in `@aws-cdk/assets` is widely used (through interface inheritance) in the Construct Library by many stable modules like Lambda, ECS, EC2, and CodeBuild. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

…ags (aws#12645) CDKv1 introduced feature flags that allowed users to opt-in to new backwards-incompatible behaviour. There are two types of flags - one set that need to be entirely removed in CDKv2 and their 'enabled' behaviour made the default, and another set where the the new behaviour should be made the default, and allow users to explicitly opt-out. This change addresses the testing strategy for the former set (and not the latter). There exist unit tests that test the behaviour both when the feature flags are enabled and feature flags and disabled. However, in v2, the feature flags will be removed and its usage blocked. The default behaviour will be as if the feature flag is enabled. Introduce branching logic that treats these unit tests depending on whether it's executed in the context of CDKv1 or CDKv2. The logic is as follows: - In the context of v1, all tests will execute as normal. - In the context of v2, tests that rely on feature flag to be unset will not be executed. - In the context of v2, tests that rely on feature flag to be set will not configure the feature flag on the App's context and continue to execute the test. This logic has been captured at a single location in two methods - `testFeatureFlag()` and `testFeatureFlagDisabled()`. To validate this logic, the unit tests that rely on the feature flags `aws-kms:defaultKeyPolicies`, `aws-secretsmanager:parseOwnedSecretName` and `core:enableStackNameDuplicates` have been updated to use these methods. Forward looking: The final PR in v2 is expected to look like this - aws#12644 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

…trategy for emrcreatecluster step The current InstanceFleetProvisioningSpecificationsProperty (https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-stepfunctions-tasks.EmrCreateCluster.InstanceFleetProvisioningSpecificationsProperty.html) only supports spot specification whereas the EMR InstanceFleetProvisioningSpecifications supports OnDemandSpecification (https://docs.aws.amazon.com/emr/latest/APIReference/API_InstanceFleetProvisioningSpecifications.html#EMR-Type-InstanceFleetProvisioningSpecifications-OnDemandSpecification). This commit adds the missing options. fixes aws#12501

Pull request has been modified.

shivlaks

I also think the integration test needs to be updated / an integration test needs to be written (either/or).

shivlaks · 2021-01-26T23:06:57Z

packages/@aws-cdk/aws-stepfunctions-tasks/lib/emr/emr-create-cluster.ts

+    /**
+     * Create a new AllocationStrategy with an arbitrary allocation strategy.
+     *
+     * @param customAllocationStrategy the allocation strategy string,
+     *   for example "lowest-price"
+     */


are there any docs links we can also point to?

Added link to the Cfn docs.

shivlaks · 2021-01-26T23:07:46Z

packages/@aws-cdk/aws-stepfunctions-tasks/lib/emr/emr-create-cluster.ts

+   * Different allocation strategies that can be used by the EMR cluster
+   */
+  export class AllocationStrategy {
+    /** lowest-price allocation strategy. */


include a link to the docs - ideally we want to provide more information to users to determine which allocation is most appropriate for their use case(s)

Done, added link to the Cfn docs.

shivlaks · 2021-01-26T23:09:31Z

packages/@aws-cdk/aws-stepfunctions-tasks/lib/emr/emr-create-cluster.ts

+   *
+   * @experimental
+   */
+  export interface OnDemandProvisioningSpecificationProperty {


sure, let's leave it alone for now. i'm not a fan of proliferating something we know we want to change because that's the way it's always been done.

but i'm happy to do it in another change. it will break more things, but that's the only way to stop the trend.

shivlaks · 2021-01-26T23:12:22Z

packages/@aws-cdk/aws-stepfunctions-tasks/lib/emr/private/cluster-utils.ts

+    SpotSpecification:
+      property.spotSpecification === undefined
+        ? property.spotSpecification
+        : SpotProvisioningSpecificationPropertyToJson(property.spotSpecification),


shouldn't the function handle that?

shivlaks · 2021-01-26T23:13:24Z

packages/@aws-cdk/aws-stepfunctions-tasks/lib/emr/private/cluster-utils.ts

+    OnDemandSpecification:
+      property.onDemandSpecification === undefined
+        ? property.onDemandSpecification
+        : OnDemandProvisioningSpecificationPropertyToJson(property.onDemandSpecification),


same question about the function. can it be more robust to return undefined if the property is undefined?

shivlaks · 2021-01-26T23:14:54Z

packages/@aws-cdk/aws-stepfunctions-tasks/lib/emr/private/cluster-utils.ts

+/**
+ * Render the SpotProvisioningSpecificationProperty to JSON
+ *
+ * @param property
+ */
+export function SpotProvisioningSpecificationPropertyToJson(property: EmrCreateCluster.SpotProvisioningSpecificationProperty) {
+  return {
+    AllocationStrategy: cdk.stringToCloudFormation(property.allocationStrategy?.name),
+    BlockDurationMinutes: cdk.numberToCloudFormation(property.blockDurationMinutes),
+    TimeoutAction: cdk.stringToCloudFormation(property.timeoutAction?.valueOf()),
+    TimeoutDurationMinutes: cdk.numberToCloudFormation(property.timeoutDurationMinutes),
+  };
+}
+
+/**
+ * Render the SpotProvisioningSpecificationProperty to JSON
+ *
+ * @param property
+ */
+export function OnDemandProvisioningSpecificationPropertyToJson(property: EmrCreateCluster.OnDemandProvisioningSpecificationProperty) {
+  return {
+    AllocationStrategy: cdk.stringToCloudFormation(property.allocationStrategy?.name),
+  };
+}
+


why do both of these need to be in a utils file? - they're only used in one file. the preference is to keep it local until there's a need (multiple usage sites) to move it to a common location.

Pull request has been modified.

aws-cdk-automation · 2021-02-14T23:24:58Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
Commit ID: 51de8a2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

shivlaks · 2021-02-23T06:52:36Z

@mohanrajendran are you still working through this PR? anything I can help with to get it going again?

shivlaks

@mohanrajendran looking close, but there are still a few unaddressed comments. is this still being worked on?

zanussbaum · 2021-07-28T17:14:40Z

Is this being actively developed? This a feature that would be a big win for our current Step Function and make migrating to flexible fleets incredibly easy for our team. Otherwise, we will need to re-haul our step function.

BenChaimberg · 2021-07-28T17:49:37Z

@zanussbaum It looks like development on this feature has stalled – please feel free to pick up the work if you are interested!

TheRealAmazonKendra · 2022-03-30T20:43:15Z

This PR has been deemed to be abandoned, and will be closed. Please create a new PR for these changes if you think this decision has been made in error.

github-actions bot added the @aws-cdk/aws-stepfunctions-tasks label Jan 14, 2021

github-actions bot assigned shivlaks Jan 14, 2021

shivlaks previously requested changes Jan 15, 2021

View reviewed changes

AWS CDK Team and others added 25 commits January 24, 2021 12:17

chore(release): 1.85.0

df49eb6

Update CHANGELOG.md

fe5ee19

Update CHANGELOG.md

ed2ef5c

Update CHANGELOG.md

3d51bc8

Update CHANGELOG.md

c824c2f

chore(aws-cdk-lib): minimum supported node version is now v14 (aws#11964

d05c98e

) This is the current active LTS version and is a good minimum requirement. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

docs(codebuild): clarify BuildEnvironmentVariable value property (a…

0a9d636

…ws#12539) Relates to aws#12478 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

feat(elasticsearch): UltraWarm nodes (aws#12265)

dc8248a

ElasticSearch-support for UltraWarm nodes including validations for necessary pre-requirements. Closes aws#6462. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

chore(ec2): add c6gn instance type metadata (aws#12525)

ed6777b

Closes aws#12381 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

chore(applicationautoscaling): Add MSK storage scaling predefined met…

1d064d0

…ric (aws#12455) Adds the missing predefined metric for MSK storage auto scaling. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

DaWyz and others added 10 commits January 24, 2021 12:17

docs(stepfunctions-tasks): Replace deprecated class name (aws#12658)

940abd1

`Data` -> `JsonPath` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Merge branch 'master' into master

b4d8a0e

Merge branch 'master' into master

21a7d30

shivlaks previously requested changes Jan 26, 2021

View reviewed changes

shivlaks changed the title ~~feat(aws-stepfunctions-tasks): adding on demand option + allocation s…~~ feat(stepfunctions-tasks): adding on demand option + allocation s… Jan 26, 2021

Merge branch 'master' into master

51de8a2

shivlaks suggested changes May 23, 2021

View reviewed changes

BenChaimberg assigned BenChaimberg and unassigned shivlaks and BenChaimberg Jul 22, 2021

RomainMuller force-pushed the master branch from 924c117 to ebfd5f2 Compare September 29, 2021 13:07

rix0rrr added feature-request A feature should be added or improved. p1 and removed @aws-cdk/aws-stepfunctions-tasks labels Mar 4, 2022

TheRealAmazonKendra closed this Mar 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(stepfunctions-tasks): adding on demand option + allocation s… #12512

feat(stepfunctions-tasks): adding on demand option + allocation s… #12512

mohanrajendran commented Jan 14, 2021

gitpod-io bot commented Jan 14, 2021 •

edited

Loading

shivlaks Jan 14, 2021

mohanrajendran Jan 24, 2021

shivlaks Jan 26, 2021

shivlaks Jan 14, 2021

mohanrajendran Jan 24, 2021

shivlaks Jan 14, 2021

mohanrajendran Jan 24, 2021

shivlaks Jan 14, 2021

mohanrajendran Jan 24, 2021

shivlaks Jan 26, 2021

shivlaks Jan 14, 2021

mohanrajendran Jan 24, 2021

shivlaks Jan 26, 2021

shivlaks Jan 15, 2021

shivlaks left a comment

shivlaks Jan 26, 2021

mohanrajendran Feb 14, 2021

shivlaks Jan 26, 2021

mohanrajendran Feb 14, 2021

shivlaks Jan 26, 2021

shivlaks Jan 26, 2021

shivlaks Jan 26, 2021

shivlaks Jan 26, 2021

aws-cdk-automation commented Feb 14, 2021

shivlaks commented Feb 23, 2021

shivlaks left a comment

zanussbaum commented Jul 28, 2021

BenChaimberg commented Jul 28, 2021

TheRealAmazonKendra commented Mar 30, 2022

feat(stepfunctions-tasks): adding on demand option + allocation s… #12512

feat(stepfunctions-tasks): adding on demand option + allocation s… #12512

Conversation

mohanrajendran commented Jan 14, 2021

gitpod-io bot commented Jan 14, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shivlaks left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aws-cdk-automation commented Feb 14, 2021

AWS CodeBuild CI Report

shivlaks commented Feb 23, 2021

shivlaks left a comment

Choose a reason for hiding this comment

zanussbaum commented Jul 28, 2021

BenChaimberg commented Jul 28, 2021

TheRealAmazonKendra commented Mar 30, 2022

gitpod-io bot commented Jan 14, 2021 •

edited

Loading