Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(codebuild): clarify BuildEnvironmentVariable value property #12539

Merged
merged 3 commits into from
Jan 15, 2021
Merged

docs(codebuild): clarify BuildEnvironmentVariable value property #12539

merged 3 commits into from
Jan 15, 2021

Conversation

blimmer
Copy link
Contributor

@blimmer blimmer commented Jan 15, 2021

Relates to #12478

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jan 15, 2021 •
edited
Loading

@github-actions github-actions bot added the @aws-cdk/aws-codebuild Related to AWS CodeBuild label Jan 15, 2021
skinny85
skinny85 previously requested changes Jan 15, 2021
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution @blimmer ! Small suggestion on the wording of the comment 🙂.

@blimmer @skinny85
Update packages/@aws-cdk/aws-codebuild/lib/project.ts
a44bdb9 
Co-authored-by: Adam Ruka <adamruka85@gmail.com>
@mergify mergify bot dismissed skinny85’s stale review January 15, 2021 19:54

Pull request has been modified.

@blimmer
Copy link
Contributor Author

blimmer commented Jan 15, 2021

Thanks @skinny85 - good to know about @link. I committed your suggestion. I think this will really help folks out :-)

skinny85
skinny85 approved these changes Jan 15, 2021
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @blimmer!

@mergify
Copy link
Contributor

mergify bot commented Jan 15, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Jan 15, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: ccbcc83
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit ea67c54 into aws:master Jan 15, 2021
mohanrajendran pushed a commit to mohanrajendran/aws-cdk that referenced this pull request Jan 24, 2021
@blimmer
docs(codebuild): clarify BuildEnvironmentVariable value property (a…
0a9d636 
…ws#12539)

Relates to aws#12478


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skinny85 skinny85 skinny85 approved these changes

Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blimmer @aws-cdk-automation @skinny85