Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove webhook/triggers from CodeBuild CF stack template #4243

Merged
merged 6 commits into from
Jul 19, 2024
Merged

Remove webhook/triggers from CodeBuild CF stack template #4243

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4c2d398
Remove webhook/triggers from CodeBuild CF stack template
Ephylouise Jul 15, 2024
a07820f
Merge branch 'dev' into dev-stephyr
Ephylouise Jul 17, 2024
c623780
Disable artifact encryption on CodeBuild devbuild stack template
Ephylouise Jul 18, 2024
89389e0
Merge branch 'dev-stephyr' of github.com:ephylouise/amazon-ecs-agent …
Ephylouise Jul 18, 2024
1b051fa
Merge branch 'dev' into dev-stephyr
Ephylouise Jul 18, 2024
699da99
Remove trailing space on EcryptionDisabled lines
Ephylouise Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 9 additions & 57 deletions build-infrastructure/codebuild-devbuild-stack.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ Resources:
Type: 'AWS::CodeBuild::Project'
Properties:
Artifacts:
EncryptionDisabled: true
Location: !Ref BuildBucketName
NamespaceType: NONE
OverrideArtifactName: true
Expand All @@ -46,18 +47,12 @@ Resources:
Location: !Ref GithubFullRepoName
Type: GITHUB
TimeoutInMinutes: 60
Triggers:
BuildType: BUILD
# Config list of developers allowlisted to create builds when creating PRs to GithubBranchName
# This allow list can be modified using aws-cli or aws-sdk
# CodeBuild also supports pattern matches using regex, but this is not useful for listing different Github IDs
# so they have to be listed separately
Webhook: true
Visibility: PRIVATE
UbuntuArmProject:
Type: 'AWS::CodeBuild::Project'
Properties:
Artifacts:
EncryptionDisabled: true
Location: !Ref BuildBucketName
NamespaceType: NONE
OverrideArtifactName: true
Expand All @@ -81,18 +76,12 @@ Resources:
Location: !Ref GithubFullRepoName
Type: GITHUB
TimeoutInMinutes: 60
Triggers:
BuildType: BUILD
# Config list of developers allowlisted to create builds when creating PRs to GithubBranchName
# This allow list can be modified using aws-cli or aws-sdk
# CodeBuild also supports pattern matches using regex, but this is not useful for listing different Github IDs
# so they have to be listed separately
Webhook: true
Visibility: PRIVATE
ArmProject:
Type: 'AWS::CodeBuild::Project'
Properties:
Artifacts:
EncryptionDisabled: true
Location: !Ref BuildBucketName
NamespaceType: NONE
OverrideArtifactName: true
Expand All @@ -116,18 +105,12 @@ Resources:
Location: !Ref GithubFullRepoName
Type: GITHUB
TimeoutInMinutes: 60
Triggers:
BuildType: BUILD
# Config list of developers allowlisted to create builds when creating PRs to GithubBranchName
# This allow list can be modified using aws-cli or aws-sdk
# CodeBuild also supports pattern matches using regex, but this is not useful for listing different Github IDs
# so they have to be listed separately
Webhook: true
Visibility: PRIVATE
AmdProject:
Type: 'AWS::CodeBuild::Project'
Properties:
Artifacts:
EncryptionDisabled: true
Location: !Ref BuildBucketName
NamespaceType: NONE
OverrideArtifactName: true
Expand All @@ -151,20 +134,14 @@ Resources:
Location: !Ref GithubFullRepoName
Type: GITHUB
TimeoutInMinutes: 60
Triggers:
BuildType: BUILD
# Config list of developers allowlisted to create builds when creating PRs to GithubBranchName
# This allow list can be modified using aws-cli or aws-sdk
# CodeBuild also supports pattern matches using regex, but this is not useful for listing different Github IDs
# so they have to be listed separately
Webhook: true
Visibility: PRIVATE

# Creates a CodeBuild project for Amazon Linux 2 ARM
Amzn2ArmProject:
Type: 'AWS::CodeBuild::Project'
Properties:
Artifacts:
EncryptionDisabled: true
Location: !Ref BuildBucketName
NamespaceType: NONE
OverrideArtifactName: true
Expand All @@ -188,20 +165,14 @@ Resources:
Location: !Ref GithubFullRepoName
Type: GITHUB
TimeoutInMinutes: 60
Triggers:
BuildType: BUILD
# Config list of developers allowlisted to create builds when creating PRs to GithubBranchName
# This allow list can be modified using aws-cli or aws-sdk
# CodeBuild also supports pattern matches using regex, but this is not useful for listing different Github IDs
# so they have to be listed separately
Webhook: true
Visibility: PRIVATE

# Creates a CodeBuild project for Amazon Linux 2 AMD
Amzn2AmdProject:
Type: 'AWS::CodeBuild::Project'
Properties:
Artifacts:
EncryptionDisabled: true
Location: !Ref BuildBucketName
NamespaceType: NONE
OverrideArtifactName: true
Expand All @@ -225,20 +196,14 @@ Resources:
Location: !Ref GithubFullRepoName
Type: GITHUB
TimeoutInMinutes: 60
Triggers:
BuildType: BUILD
# Config list of developers allowlisted to create builds when creating PRs to GithubBranchName
# This allow list can be modified using aws-cli or aws-sdk
# CodeBuild also supports pattern matches using regex, but this is not useful for listing different Github IDs
# so they have to be listed separately
Webhook: true
Visibility: PRIVATE

# Creates a CodeBuild project for Amazon Linux 2023 ARM
Amzn2023ArmProject:
Type: 'AWS::CodeBuild::Project'
Properties:
Artifacts:
EncryptionDisabled: true
Location: !Ref BuildBucketName
NamespaceType: NONE
OverrideArtifactName: true
Expand All @@ -262,20 +227,14 @@ Resources:
Location: !Ref GithubFullRepoName
Type: GITHUB
TimeoutInMinutes: 60
Triggers:
BuildType: BUILD
# Config list of developers allowlisted to create builds when creating PRs to GithubBranchName
# This allow list can be modified using aws-cli or aws-sdk
# CodeBuild also supports pattern matches using regex, but this is not useful for listing different Github IDs
# so they have to be listed separately
Webhook: true
Visibility: PRIVATE

# Creates a CodeBuild project for Amazon Linux 2023 AMD
Amzn2023AmdProject:
Type: 'AWS::CodeBuild::Project'
Properties:
Artifacts:
EncryptionDisabled : true
Location: !Ref BuildBucketName
NamespaceType: NONE
OverrideArtifactName: true
Expand All @@ -299,13 +258,6 @@ Resources:
Location: !Ref GithubFullRepoName
Type: GITHUB
TimeoutInMinutes: 60
Triggers:
BuildType: BUILD
# Config list of developers allowlisted to create builds when creating PRs to GithubBranchName
# This allow list can be modified using aws-cli or aws-sdk
# CodeBuild also supports pattern matches using regex, but this is not useful for listing different Github IDs
# so they have to be listed separately
Webhook: true
Visibility: PRIVATE

# Defines the service roles for the CodeBuild projects
Expand Down Expand Up @@ -652,4 +604,4 @@ Resources:
- 's3:GetBucketAcl'
- 's3:GetBucketLocation'
PolicyName: !Sub '${AWS::StackName}-ServicePolicyAmzn2023Amd'
RoleName: !Sub '${AWS::StackName}-ServiceRoleAmzn2023Amd'
RoleName: !Sub '${AWS::StackName}-ServiceRoleAmzn2023Amd'
Loading