Remove webhook/triggers from CodeBuild CF stack template #4243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparrc
previously approved these changes
Jul 16, 2024
yinyic
approved these changes
Jul 19, 2024
sparrc
approved these changes
Jul 19, 2024
Yiyuanzzz
pushed a commit
to Yiyuanzzz/amazon-ecs-agent
that referenced
this pull request
Jul 19, 2024
…ove webhook Booleans (aws#4243) * Remove webhook/triggers from CodeBuild CF stack template * Disable artifact encryption on CodeBuild devbuild stack template * Remove trailing space on EcryptionDisabled lines
xxx0624
pushed a commit
to xxx0624/amazon-ecs-agent
that referenced
this pull request
Jul 29, 2024
…ove webhook Booleans (aws#4243) * Remove webhook/triggers from CodeBuild CF stack template * Disable artifact encryption on CodeBuild devbuild stack template * Remove trailing space on EcryptionDisabled lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit updates the CodeBuild CloudFormation stack template by:
EncryptionDisabled: trueto allow cross-account access of artifactsImplementation details
The CloudFormation template is used to create or update CodeBuild (CB) projects. This update removes webhook triggers that were baked into the template, because webhooks require specific permissions and should be handled separately from the creation of any new projects.
Webhook triggers can and will still be incorporated into the CB projects, even when using this template to update a stack. An update_users script should be run to restore webhook filter groups for each team members' GitHub user account.
The following steps describe the implementation of a current production stack update to create 4 new CodeBuild projects.
cloudformation create-change-setcloudformation execute-change-setEncryption is disabled for All-Dogs artifacts to allow cross-account S3 access. This will enable MACIS to access the artifacts from different regions, which is necessary for thorough integration testing.
Testing
The template has been tested through creating and executing a change-set a personal AWS account. Followed by performing the above steps in the development AWS account to introduce the 4 new CodeBuild projects.
Description for the changelog
Removes webhook Boolean and disables artifact encryption from CodeBuild CloudFormation stack template.
Does this PR include breaking model changes? If so, Have you added transformation functions?
No.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.