#2389 (95de310) with changes in dev branch #2393
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, dockerclient ecs, ecr, ecs_client and ecscni directories
…nctional_tests, gogenerate, gpu, handlers packages
GetBucketLocation returns null for bucket in us-east-1. Return us-east-1 instead of null in that case.
for roadmap issue #385 aws/containers-roadmap#385 this commit adds the ability for customers to add parameters to the secretsmanager ARN specified in containers. agent will be able to retrieve secret by version or retrieve part of a secret by json key. this commit also fixes a minor issue breaking go vet in an unrelated test.
ECS support JSON key and version for secrets
* Address CPU usage metric corner cases 1. If two metrics arrive with identical timestamps, set cpu usage to previous value rather than leaving it at NaN 2. Ensure that we don't emit cloudwatch metrics with sampleCount == 0 3. Make storage sets behavior consistent with cpu and memory 4. log when cpu usage is larger than tacs cap * Do not cap CPU Usage percent we want to be aware of when this happens, also added a detailed log message for further debugging. * code review: fix capital letters
we are removing this env var from our docs because it was never intended
to be a publically-configurable variable.
for this env var to function it needs to be integrated with ecs-init and
the directory needs to be mounted in docker, so it has never
functioned the way customers would expect.
update ASM error message to be more clear
|
Since #2389 test all passed, close this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
this change has the latest changes in dev merged in; these changes are needed to pass the CI tests. This pull request will be closed after verifying the test results.
Implementation details
Testing
New tests cover the changes:
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.