Address CPU usage metric corner cases #2366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Cap cpu usage percent at 1024*1024 to match telemetry codebase 2. If two metrics arrive with identical timestamps, set cpu usage to previous value rather than leaving it at NaN 3. Ensure that we don't emit cloudwatch metrics with sampleCount == 0 4. Make storage sets behavior consistent with cpu and memory
yumex93
previously approved these changes
Feb 17, 2020
yhlee-aws
previously approved these changes
Feb 17, 2020
instead we want to be aware of when this happens, also added a detailed log message for further debugging.
28337a3 to
2b1495d
Compare
significant changes have been added to PR
mssrivas
approved these changes
Feb 18, 2020
fenxiong
reviewed
Feb 18, 2020
89d16a9 to
34ac24a
Compare
fenxiong
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(this is a recreation of #2361)
Summary
This PR changes a few corner cases in the CPU percent metrics handling:
Cap cpu usage percent at 1024*1024 to match telemetry codebaseallow large cpu usage percents to get sent to telemetry backend but log a detailed error message.Testing
New unit tests were added to cover these changes
New tests cover the changes: yes
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.