-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(event_handler): add type annotations for router decorators #5601
refactor(event_handler): add type annotations for router decorators #5601
Conversation
Should I use |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5601 +/- ##
========================================
Coverage 96.14% 96.14%
========================================
Files 229 229
Lines 10854 10854
Branches 2018 2018
========================================
Hits 10436 10436
Misses 329 329
Partials 89 89 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rafrafek! Thanks for sending this PR and sorry for delay in replying it.
Just a small comment about using an existing type instead of creating a new one. If it work, please import it under TYPE_CHECKING
section.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for addressing the feedback @rafrafek!
APPROVED!
Issue number: #3990
Summary
Adds type annotations for Api Gateway Router decorators to improve Pyright compatibility. Fixes Pyright error
Untyped function decorator obscures type of function
when used in "strict" type checking mode. May be helpful especially for VS Code users.Changes
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.