refactor(typing): Update event_handler to pass strict checks #5139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing out moving an
APIGatewayRestResolver
projects to runmypy
in strict mode, I noticed that 4 areas were failing type inference:throws:
error: Call to untyped function "Router" in typed context [no-untyped-call]
and
throws:
error: Untyped decorator makes function "hello_get" untyped [misc]
and
throws:
error: Untyped decorator makes function "handle_generic_exception" untyped [misc]
and
throws:
error: Call to untyped function "append_context" in typed context [no-untyped-call]
Issue number:
Summary
Changes
Added some simple type definitions to affected areas of these 4 components.
User experience
The above code examples will not raise errors when running
mypy --strict
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.