-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(typing): improve overloads to ensure the return type follows the default_value type #4114
Conversation
eb95f0a
to
b10e803
Compare
b10e803
to
3be8659
Compare
@Wurstnase it seems some tests are failing, can you please look at them? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #4114 +/- ##
===========================================
- Coverage 96.38% 96.25% -0.13%
===========================================
Files 214 216 +2
Lines 10030 10394 +364
Branches 1846 1921 +75
===========================================
+ Hits 9667 10005 +338
- Misses 259 275 +16
- Partials 104 114 +10 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing work, thank you VERY much!! I left some small nit picks here and there that should be easy to fix. I loved to see the test changing at the end to remove the type ignore!
aws_lambda_powertools/utilities/data_classes/shared_functions.py
Outdated
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stellar work, thank you so much for spending time improving the experience here. Seriously, thank you!
Issue number: #4113
Summary
Changes
Overload functions with
default_value
when it becomes notOptional
anymore.User experience
Ensure return type without casting.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.