Skip to content

Commit

Permalink
chore: review findings
Browse files Browse the repository at this point in the history
  • Loading branch information
Wurstnase committed Apr 12, 2024
1 parent 37d6468 commit f190a13
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 13 deletions.
4 changes: 2 additions & 2 deletions aws_lambda_powertools/utilities/data_classes/kafka_event.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,15 +74,15 @@ def get_header_value(
self,
name: str,
default_value: str,
case_sensitive: bool = False,
case_sensitive: bool = True,
) -> str: ...

@overload
def get_header_value(
self,
name: str,
default_value: Optional[str] = None,
case_sensitive: bool = False,
case_sensitive: bool = True,
) -> Optional[str]: ...

def get_header_value(
Expand Down
22 changes: 11 additions & 11 deletions aws_lambda_powertools/utilities/data_classes/shared_functions.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from __future__ import annotations

import base64
from typing import Any, overload
from typing import Any, Dict, overload


def base64_decode(value: str) -> str:
Expand All @@ -26,7 +26,7 @@ def get_header_value(
headers: dict[str, Any],
name: str,
default_value: str,
case_sensitive: bool | None = None,
case_sensitive: bool | None = False,
) -> str: ...


Expand All @@ -35,29 +35,29 @@ def get_header_value(
headers: dict[str, Any],
name: str,
default_value: str | None = None,
case_sensitive: bool | None = None,
case_sensitive: bool | None = False,
) -> str | None: ...


def get_header_value(
headers: dict[str, Any],
name: str,
default_value: str | None = None,
case_sensitive: bool | None = None,
case_sensitive: bool | None = False,
) -> str | None:
"""
Get the value of a header by its name.
Parameters
----------
headers: dict[str, str]
headers: Dict[str, str]
The dictionary of headers.
name: str
The name of the header to retrieve.
default_value: str, optional
The default value to return if the header is not found. Default is None.
case_sensitive: bool, optional
Indicates whether the header name should be case-sensitive. Default is None.
Indicates whether the header name should be case-sensitive. Default is False.
Returns
-------
Expand All @@ -82,22 +82,22 @@ def get_header_value(

@overload
def get_query_string_value(
query_string_parameters: dict[str, str] | None,
query_string_parameters: Dict[str, str] | None,
name: str,
default_value: str,
) -> str: ...


@overload
def get_query_string_value(
query_string_parameters: dict[str, str] | None,
query_string_parameters: Dict[str, str] | None,
name: str,
default_value: str | None = None,
) -> str | None: ...


def get_query_string_value(
query_string_parameters: dict[str, str] | None,
query_string_parameters: Dict[str, str] | None,
name: str,
default_value: str | None = None,
) -> str | None:
Expand All @@ -121,7 +121,7 @@ def get_query_string_value(


def get_multi_value_query_string_values(
multi_value_query_string_parameters: dict[str, list[str]] | None,
multi_value_query_string_parameters: Dict[str, list[str]] | None,
name: str,
default_values: list[str] | None = None,
) -> list[str]:
Expand All @@ -137,7 +137,7 @@ def get_multi_value_query_string_values(
Returns
-------
list[str]. optional
List[str]. optional
The values of the query string parameter if found, or the default values if not found.
"""

Expand Down

0 comments on commit f190a13

Please sign in to comment.