Revert Python Template Changes - Wait for regression fix #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willarmiros
approved these changes
Nov 2, 2021
willarmiros
reviewed
Nov 3, 2021
There was a problem hiding this comment.
Waiting for @wangzlei review - will agree with his decision
wangzlei
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Reverts #165
The regression is still an issue, but we would rather have the
main-build.ymlworkflow fail because this tells us that the current local implementation has a regression and should not be published.Otherwise, if we do not do this, the
canary.ymlworkflow fails because it uses the template to test the latest published version. Since we will not publish a version with a regression, we would rather thecanary.ymlfile continue to use the template which works with the latest published Layer.Link to tracking Issue:
Regression issue is being tracked in OTel Collector Contrib: open-telemetry/opentelemetry-collector-contrib#6109
Testing:
N/A,
canary.ymlshould pass andmain-build.ymlshould fail.Documentation:
N/A