[Regression] Update expected python template for new OTel Python AWS SDK Instrumentation #165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OTel Python has updated their instrumentation to not populate the
aws.operation
attribute anymore. They did this because the specification defined how to instrument the AWS SDK.We updated the template on the test-framework to account for this change, but as the
main-build.yml
revealed, we were expecting the "operation" on the trace INFERRED BY AWS X-RAY SERVICE TEAM:aws-otel-lambda/adot/utils/expected-templates/python.json
Lines 24 to 32 in 5dd1b69
However, the service team implementation must not know to read from the metadata attributes as this spec is so new.
Impact
Before - user could see
ListBuckets
in the X-Ray console at these points:After - now, user cannot see anything here:
However, they can still find the "operation" if they look at the metadata of the subsegment span sent by OpenTelemetry Python (previously and still now):
Solutions
rpc.method
toaws.operation
and that way the service team implementation can pick it up as isrpc.method
instead ofaws.operation
to populate the operation.Link to tracking Issue:
N/A
Testing:
This template is what decides the test.
Documentation:
N/A