Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prometheus feature gate disable #2455

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Remove prometheus feature gate disable #2455

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d94b22f
Remove prom feature gate disable
bryan-aguilar Nov 1, 2023
b79bc23
Merge branch 'main' into removePromFeatGate
bryan-aguilar Nov 1, 2023
2b7b59f
Merge branch 'main' into removePromFeatGate
bryan-aguilar Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions cmd/awscollector/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,20 +90,11 @@ func main() {

// Override upstream feature gates and print warning messages
func handleBreakingChanges(featgate *featuregate.Registry) error {
// TODO: remove after ADOT Collector v0.34.0 is released
if err := featgate.Set("pkg.translator.prometheus.NormalizeName", false); err != nil {
return err
}

// TODO: remove after ADOT Collector v0.35.0 is released
log.Printf("attn: users of the prometheus or prometheusremotewrite exporter please refer to " +
"https://github.com/aws-observability/aws-otel-collector/issues/2367 in regards to an ADOT Collector v0.35.0 " +
"breaking change")

// TODO: remove after ADOT Collector v0.34.0 is released
log.Printf("attn: users of the statsd receiver please refer to " +
"https://github.com/aws-observability/aws-otel-collector/issues/2249 in regards to an ADOT Collector v0.33.0 " +
"breaking change")
// TODO: remove after ADOT Collector v0.35.0 is released
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we keep this todo, not required though

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is kept. I just moved it to be above the other log line that also needs to be removed.

log.Printf("attn: users of the awscontainerinsightreceiver please refer to " +
"https://github.com/aws-observability/aws-otel-collector/issues/2317 in regards to an ADOT Collector v0.35.0 " +
"breaking change")
Expand Down