Remove prometheus feature gate disable #2455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasireddy99
approved these changes
Nov 1, 2023
| log.Printf("attn: users of the statsd receiver please refer to " + | ||
| "https://github.com/aws-observability/aws-otel-collector/issues/2249 in regards to an ADOT Collector v0.33.0 " + | ||
| "breaking change") | ||
| // TODO: remove after ADOT Collector v0.35.0 is released |
There was a problem hiding this comment.
Shall we keep this todo, not required though
There was a problem hiding this comment.
It is kept. I just moved it to be above the other log line that also needs to be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Remove logic that disabled
pkg.translator.prometheus.NormalizeNameby defaultLink to tracking Issue: #2367
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.