removing unnecessary regional resource specification patching #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
4404b23 to
49f73c0
Compare
similar to #1553 https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/cfn-resource-specification.html https://cfn-resource-specifications-ap-northeast-3-prod.s3.ap-northeast-3.amazonaws.com/latest/gzip/CloudFormationResourceSpecification.json https://cfn-resource-specifications-ap-southeast-2-prod.s3.ap-southeast-2.amazonaws.com/latest/gzip/CloudFormationResourceSpecification.json https://cfn-resource-specifications-ap-southeast-1-prod.s3.ap-southeast-1.amazonaws.com/latest/gzip/CloudFormationResourceSpecification.json https://cfn-resource-specifications-ap-south-1-prod.s3.ap-south-1.amazonaws.com/latest/gzip/CloudFormationResourceSpecification.json
kddejong
approved these changes
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
similar to #1553
relevant Resource Specifications for
01_spec_patch.jsonremovals:ap-northeast-3ap-southeast-1ap-south-1ap-southeast-2(only remaining manual regional patches from #706), wondering if there are problems with this format:https://github.com/aws-cloudformation/cfn-python-lint/blob/81f0e3f845ff59b3cf6cc104f80ff71eec6a2164/scripts/update_specs_services_from_ssm.py#L85
Even though they are not in those Resource Specifications, I believe the
AWS::Cognito::UserPoolUser.AttributeTypepatches can also be removed becauseAWS::Cognito::UserPoolUseris not present in those regions either (not even in the patches automatically generated from SSM): (context: #1002, #1003)AWS::Cognito::UserPoolUser.AttributeTypeis also in theus-east-1Resource Specification, so it should get picked up ifAWS::Cognito::UserPoolUsergets picked up anywayRegional
ConfigResourceTypeAllowedValues added here were switched away from being regionally maintained here:https://github.com/aws-cloudformation/cfn-python-lint/blob/de078a9274e13b0b44a6e730ff11a3def717080f/src/cfnlint/data/ExtendedSpecs/all/03_value_types/aws_config.json#L4