Fix Property Check Failing for AWS::Cognito::UserPool in ap-southeast-1 #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1003 +/- ##
=======================================
Coverage 86.83% 86.83%
=======================================
Files 133 133
Lines 7878 7878
Branches 1939 1939
=======================================
Hits 6841 6841
- Misses 638 639 +1
+ Partials 399 398 -1
Continue to review full report at Codecov.
|
|
Thanks for submitting this. I will take a look shortly. |
kddejong
approved these changes
Jul 9, 2019
svenstaro
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Jul 22, 2020
Also added a patch that fixes test failures in python-aws-sam-translator. The patch is from a merged pull request [1]. [1] aws-cloudformation/cfn-lint#1003 git-svn-id: file:///srv/repos/svn-community/svn@487733 9fca08f4-af9d-4005-b8df-a31f2cc04f65
svenstaro
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Jul 22, 2020
pr1003 [1] has been merged. [1] aws-cloudformation/cfn-lint#1003 git-svn-id: file:///srv/repos/svn-community/svn@488614 9fca08f4-af9d-4005-b8df-a31f2cc04f65
PatMyron
added a commit
that referenced
this pull request
Aug 29, 2020
PatMyron
added a commit
that referenced
this pull request
Aug 29, 2020
PatMyron
added a commit
that referenced
this pull request
Aug 30, 2020
kddejong
pushed a commit
that referenced
this pull request
Aug 31, 2020
* removing unnecessary regional resource specification patching similar to #1553 https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/cfn-resource-specification.html https://cfn-resource-specifications-ap-northeast-3-prod.s3.ap-northeast-3.amazonaws.com/latest/gzip/CloudFormationResourceSpecification.json https://cfn-resource-specifications-ap-southeast-2-prod.s3.ap-southeast-2.amazonaws.com/latest/gzip/CloudFormationResourceSpecification.json https://cfn-resource-specifications-ap-southeast-1-prod.s3.ap-southeast-1.amazonaws.com/latest/gzip/CloudFormationResourceSpecification.json https://cfn-resource-specifications-ap-south-1-prod.s3.ap-south-1.amazonaws.com/latest/gzip/CloudFormationResourceSpecification.json * removing AWS::Cognito::UserPoolUser.AttributeType regional patches https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/cfn-resource-specification.html #1002 #1003 * removing regional ConfigResourceType AllowedValues patching Regional ConfigResourceType AllowedValues added here: #654 were switched away from being regionally maintained here: #1074
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1002
Description of changes:
I updated ap-southeast-1.json with the 'types' from the ap-southeast-2.json file. From local testing, it looks like that this fixes the issue mentioned above.
Was previously throwing "E0002: Error processing rule on the template (Unknown exception while processing rule E3002: 'AWS::Cognito::UserPool.Policies') on files such as this test file.
Please let me know if there is anything I should change on this! Thanks
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.