Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api) owner with readonly access should be able to sub to on_delete, on_create, on_update #807

Merged
merged 3 commits into from
Sep 8, 2020

Conversation

richardmcclellan
Copy link
Contributor

Same as #779, but with updated unit tests.

Fixes #778 and #699.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@richardmcclellan richardmcclellan requested a review from a team September 8, 2020 19:07
@richardmcclellan richardmcclellan changed the title fix(api) Fix logic for determining when owner argument should be added to subscription requests fix(api) owner with readonly access should be able to sub to on_delete, on_create, on_update Sep 8, 2020
Copy link
Contributor

@TrekSoft TrekSoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cat22u2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seems out of place that we are checking ModelOperation in isOwnerArgumentRequired
3 participants