fix[datastore] owner with readonly access should be able to sub to on_delete, on_create, on_update #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_delete, on_create, on_update solves aws-amplify#778
There was a problem hiding this comment.
I did some testing to confirm this change will work (detailed in #699), and it looks good to me.
I will approve this PR, pending updated unit tests. Thanks for this contribution @saltonmassally!
Somewhat related, we would like to get better integration test coverage in the future, so that issues like this can be verified through tests.
|
Closing in favor of #807 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #778
Issue #, if available:
#778
Description of changes:
If user has read access to a model they should be able to observe on_delete, on_create, and on_update events
Units tests are failing now some of which will be unnecessary if we are proceeding with this. WIll fix if we are at a consensus on this change
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.